Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 317438

Summary: [Model] Replace Rendered* and Opaque* through the use of tags and the new transientData slot
Product: [Eclipse Project] e4 Reporter: Thomas Schindl <tom.schindl>
Component: UIAssignee: Project Inbox <e4.ui-inbox>
Status: RESOLVED WORKSFORME QA Contact:
Severity: normal    
Priority: P3 CC: emoffatt, pwebster, remy.suen
Version: 0.9   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=402764
Whiteboard: stalebug
Bug Depends on:    
Bug Blocks: 324957    

Description Thomas Schindl CLA 2010-06-21 09:13:38 EDT
Those 2 types are not really meant for usage by customers. I think we should move them to an extra .ecore in the area they are used (most likely in the org.eclipse.ui.workbench-bundle)
Comment 1 Eric Moffatt CLA 2010-06-22 15:00:31 EDT
Post release we should re-examine all the changes we've made in the last while to see what's there...
Comment 2 Eric Moffatt CLA 2010-09-20 10:25:35 EDT
Tom, for now how about just moving them to their own package? I'm just trying to limit complexity, if we have have multiple ecore models then the upgrade story will get much more complicated won't it?
Comment 3 Thomas Schindl CLA 2010-09-20 10:39:06 EDT
Which upgrade process you are talking about 4.0 to 4.1? 

I personally think that we are going to have 1 or 2 breaking changes in our model (the keybinding story is probably one of them). This change only affects internal code because 2 those types are only created at runtime and deleted before shutdown by the compat layer (it does not get part of deltas - Paul/Remy can correct me on this)
Comment 4 Thomas Schindl CLA 2010-09-21 07:44:49 EDT
Looking on the RenderedToolbar/RenderedMenu can't we simply remove them. 

To make storeing arbitary runtime information I think we should add a transient-Map-attribute to ApplicationElement or UIElement.

Eric/Paul/Remy thoughts on this?
Comment 5 Remy Suen CLA 2010-09-21 07:49:38 EDT
(In reply to comment #3)
> This change only affects
> internal code because 2 those types are only created at runtime and deleted
> before shutdown by the compat layer (it does not get part of deltas - Paul/Remy
> can correct me on this)

MRenderedToolBars of views do get persisted actually.

(In reply to comment #4)
> To make storeing arbitary runtime information I think we should add a
> transient-Map-attribute to ApplicationElement or UIElement.

This would just be a Map<Object, Object>?
Comment 6 Thomas Schindl CLA 2010-09-21 07:53:23 EDT
[...]
> 
> MRenderedToolBars of views do get persisted actually.
> 
> (In reply to comment #4)
> > To make storeing arbitary runtime information I think we should add a
> > transient-Map-attribute to ApplicationElement or UIElement.
> 
> This would just be a Map<Object, Object>?

I'd prefer a Map<String,Object>
Comment 7 Eclipse Genie CLA 2018-12-08 13:31:16 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 8 Lars Vogel CLA 2019-06-05 07:36:45 EDT
This is a mass change to close all e4 bugs marked with "stalebug" whiteboard.

If this bug is still valid, please reopen and remove the "stalebug" keyword.