Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 317423

Summary: [Model] Get rid of the AbstractContainers like PartDescriptorContainer, ...
Product: [Eclipse Project] e4 Reporter: Thomas Schindl <tom.schindl>
Component: UIAssignee: Thomas Schindl <tom.schindl>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: bokowski, john.arthorne, pwebster, remy.suen
Version: 0.9   
Target Milestone: 1.0 RC1   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Attachments:
Description Flags
Patch none

Description Thomas Schindl CLA 2010-06-21 07:57:33 EDT 
Some of the containers we defined where solely used by Application and our old Model-Contribution story and hence are "useless" now:
* PartDescriptorContainer
* BindingTableContainer

Stuff I'm unsure why we have containers are:
* TrimContributions
* MenuContributions
* ToolBarContributions

but to me it looks like they are only used by Application-class so beside that I guess they are abstract, right?
Comment 1 Thomas Schindl CLA 2010-06-21 08:00:01 EDT 
if we decide against removing them we should make them at least abstract (talking about the *Contribution classes)
Comment 2 Thomas Schindl CLA 2010-06-21 08:56:24 EDT 
Created attachment 172325 [details]
Patch

I just tried and removing them at this point in the cycle is probably too hard so I simply marked all of them interface=true, abstract=true

The only compiler error I saw when removing whole classes was that the reconciler was failing.
Comment 3 Thomas Schindl CLA 2010-06-22 14:09:44 EDT 
anyone a +1?
Comment 4 Thomas Schindl CLA 2010-06-23 10:16:43 EDT 
released to HEAD