Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 317396

Summary: [installer] Installing feature into bundle pool using p2 director fails
Product: [Eclipse Project] Equinox Reporter: latha <latha.nagaraj>
Component: p2Assignee: P2 Inbox <equinox.p2-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: Ed.Merks, pascal
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
the properties file used by the p2 installer to specify bundle pool none

Description latha CLA 2010-06-21 01:37:42 EDT 
Build Identifier: 1) p2 installer : 3.6 RC4 (from location http://www.eclipse.org/downloads/download.php?file=/equinox/drops/S-3.6RC4-201006031500/equinox.p2.installer-3.6RC4-win32.win32.x86.zip)   2)  p2 director used from eclipse installation version: 3.6 RC4, build number I20100603-1500 

Using the 3.6 RC4 p2 installer installed eclipse in shared mode. The bundle pool for the installation was specified in the properties file refered in the .ini file of the p2 installer.
The eclipse installation goes through fine and all the bundles are found in the bundle pool folder.
Now installing the feature using the p2 director command into the bundle pool fails.


Reproducible: Always

Steps to Reproduce:
1. download the 3.6 RC4 installer (http://www.eclipse.org/downloads/download.php?file=/equinox/drops/S-3.6RC4-201006031500/equinox.p2.installer-3.6RC4-win32.win32.x86.zip)

2. unzip the installer to folder (say D:\latha\work\p2-analysis\try1-testing-rc4-installaer\equinox.p2.installer-3.6RC4-win32.win32.x86)

3. create a properties file with the settings required to install.(attached is the file sdkprops.txt).
   Specify the bundlepool property (example: mypool)

4. place the file under a directory (Say D:\latha\work\p2-analysis\try2-testing-rc4-installer-custpool\installations\inst1\sdkprops.txt
   modify the p2installer.ini in the p2 installation folder to refer to this properties file.
   The p2installer.ini shall look like this:

    -vmargs
    -Xmx512m
    -Dorg.eclipse.equinox.p2.installDescription=file:/D:\latha\work\p2-analysis\try2-testing-rc4-installer-custpool\installations\inst1\sdkprops.txt

5. lauched the p2 installer app in that location.

6. Provide the install location (say D:\latha\work\p2-analysis\try2-testing-rc4-installer-custpool\installations\inst1)

7. Select the install option as "shared install and clicked on finish

8. The installation goes through fine. 
   The plugins are all placed under the p2 installation folder. (in my case the path D:\latha\work\p2-analysis\try2-testing-rc4-installer-custpool\equinox.p2.installer-3.6RC4-win32.win32.x86\eclipse\mypool)

9. Launching the eclipse installed is fine.

10. Now install a feature using the below mentioned director command
    eclipsec.exe -application org.eclipse.equinox.p2.director
                 -repository file://D:\latha\work\p2-analysis\workspaces\rc4-ws\mysite,http://download.eclipse.org/releases/helios
                 -installIU myfeature.feature.group -destination D:/latha/work/p2-analysis/try2-testing-rc4-installer-custpool/installations/inst1 
                 -profile "D\:/latha/work/p2-analysis/try2-testing-rc4-installer-custpool/installations/inst1"
                 -bundlepool "D:\latha\work\p2-analysis\try2-testing-rc4-installer-custpool\equinox.p2.installer-3.6RC4-win32.win32.x86\eclipse\mypool"



Actual result:
        The command executes successfully. 
        The plugin jars belonging to the feature (myfeature.feature.group) are seen under the bundle pool directory.
        Launching eclipse however does not have the plugin installed in step 10.
        The bundles.info of the eclipse installation also does not list the plugin/feature (myfeature.feature.group)

Expected result:
        Launching eclipse should have had the plugin installed to the pool. 
        The bundles.info of the eclipse installation should have listed the plugin/feature (myfeature.feature.group)       

Observations: The installer names the profile implicitly. The name looks like the name of the installation directory "D\:/latha/work/p2-analysis/try2-testing-rc4-installer-custpool/installations/inst1"
              Not sure if this is leading to the failure.

              After installing the feature using the director command in step 10, installing the feature using "install new software" of the eclipse, 
              makes a private copy of the plugins jars under the eclipse installation folder with  the name of the folder as that of bundle pool. 
              In my case the folder is D:\latha\work\p2-analysis\try2-testing-rc4-installer-custpool\installations\inst1\mypool
Comment 1 latha CLA 2010-06-21 01:39:27 EDT 
Created attachment 172303 [details]
the properties file used by the p2 installer to specify bundle pool
Comment 2 Pascal Rapicault CLA 2010-06-21 22:03:14 EDT 
The installer is not really meant to be used outside of a initial installation. I can't know for sure what is going on here, but instead I would recommend using the director.application shipped with the eclipse SDK.
Also in 3.6 the arguments that need to be passed to the director application can greatly be reduced.
Comment 3 Eclipse Webmaster CLA 2019-09-06 16:06:59 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 4 Ed Merks CLA 2020-02-19 05:34:17 EST 
Sorry, there is no resource for issues such as this.  As suggested, everyone just uses the director application (though that has a long list of issues for it as well).