Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 317395

Summary:	Method org.eclipse.cdt.codan.core.param.FileScopeProblemPreference.exportPathList(String, IPath[]) concatenates strings using + in a loop
Product:	[Tools] CDT	Reporter:	Meisam <meisam.fathi>
Component:	cdt-codan	Assignee:	Project Inbox <cdt-core-inbox>
Status:	RESOLVED WONTFIX	QA Contact:	Elena Laskavaia <elaskavaia.cdt>
Severity:	normal
Priority:	P3	CC:	cdtdoug
Version:	7.0
Target Milestone:	---
Hardware:	PC
OS:	All
Whiteboard:

Description Meisam

2010-06-20 23:45:28 EDT

This is a performance issue reported by Findbugs.

A StringBuffer can be used for achieving better performance.

Comment 1 Elena Laskavaia

2010-06-21 12:11:51 EDT

When I said open bugs for findbugs issues I meant BUGS. I am not going to change code that uses +. It reads better and it is not high impact code by any means - it only calls ones when prefers stored. Same about other "inefficiencies" such as keySet iterator.

Comment 2 Meisam

2010-06-22 09:27:23 EDT

Thanks for clarifying:) I'll report real bugs.