Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 317336

Summary:

TCFDataModel calling TCF service on non-TCF thread

Product:

[Tools] CDT

Reporter:

John Cortell <john.cortell>

Component:

cdt-debug-edc

Assignee:

Ken Ryall <ken.ryall>

Status:

RESOLVED FIXED

QA Contact:

Ken Ryall <ken.ryall>

Severity:

normal

Priority:

Flags:

ken.ryall: review+

Version:

7.0

Target Milestone:

---

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Fix	john.cortell: iplog-

Description John Cortell

2010-06-18 16:17:07 EDT

This happens in TCFDataModel.buildDataModel(IProgressMonitor). My guess as to why this went undetected is that assertions were not enabled in the runtime workbench.

Also, the same code fails to complete the progress monitor it is given.

Comment 1 John Cortell

2010-06-18 16:18:09 EDT

Created attachment 172255 [details]
Fix

Committed to HEAD. Ken, please review.

Comment 2 John Cortell

2010-06-18 16:18:46 EDT

Fixed.

Comment 3 CDT Genie

2010-06-18 16:23:05 EDT

*** cdt cvs genie on behalf of jcortell ***
Bug 317336: TCFDataModel calling TCF service on non-TCF thread

[*] TCFDataModel.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc.ui/src/org/eclipse/cdt/debug/edc/internal/ui/views/TCFDataModel.java?root=Tools_Project&r1=1.1&r2=1.2

Comment 4 Ken Ryall

2010-06-21 14:11:53 EDT

Thanks John, I did forget to turn on assertions in my new workspace.