Bugzilla – Full Text Bug Listing
| Summary: | Refactoring: Unroll Loop - CQ 4297 (approved) | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] PTP | Reporter: | Ashley Kasza <akasza2> | ||||||||||||||||||
| Component: | Photran.Refactoring Engine | Assignee: | Ashley Kasza <akasza2> | ||||||||||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||||||||||
| Severity: | enhancement | ||||||||||||||||||||
| Priority: | P2 | CC: | akasza2, com-eclipse-dot-org | ||||||||||||||||||
| Version: | 5.0 | ||||||||||||||||||||
| Target Milestone: | 7.0 | ||||||||||||||||||||
| Hardware: | PC | ||||||||||||||||||||
| OS: | Windows 7 | ||||||||||||||||||||
| Whiteboard: | |||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
Created attachment 172233 [details]
same patch except with updated plugin.xml
This is the same patch as the one previously posted, except including the modified plugin.xml file.
Thanks. Can you please confirm that 1. you wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others, 2. you have the right to contribute the code to Eclipse, and 3. you have included the EPL license header in all source files? Ashley -- Reassigning this to you temporarily while you make the changes we discussed today. Please reassign to me after you have a new patch. Thanks. Created attachment 172515 [details]
updated Loop Unrolling
Made small changes (updated some error checking, and added handling of int expressions).
1. I wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others, 2. I have the right to contribute the code to Eclipse, and 3. I have included the EPL license header in all source files. Thanks. This is significanly larger than 250 LOC (closer to 1000), so we will need to file a CQ. I will wait until after the code review Friday in case there are other changes to make. Created attachment 173041 [details]
Update for Loop Unrolling
Updated some preconditions, also fixed/changed some functionality.
CQ 4297 Submitted https://dev.eclipse.org/ipzilla/show_bug.cgi?id=4297 Created attachment 173126 [details]
small update Loop Unrolling
Small fix.
Created attachment 174298 [details]
small bug fix
Updated a small bug fix
Created attachment 179322 [details]
Revised patch - renamed, messages committed
I committed the externalized strings and plugin.xml changes to CVS, but the
unit tests are not passing, so I did not commit the refactoring itself or the
test suite. Ashley, could you please replace your sources from HEAD (i.e., get
rid of your local changes), then apply the REVISED patch (attached), and see
why the tests are failing? When it is fixed, please attach a revised revised
patch. Thanks.
Created attachment 179339 [details]
revised revised loop unroll
another small bug fix.
Committed to HEAD. Thanks, Ashley! |
Created attachment 172227 [details] LoopUnrollingRefactoring Refactoring to unroll a loop any number of times, or completely.