Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 317305

Summary: [Compatibility] Menus have many separators in them
Product: [Eclipse Project] e4 Reporter: Paul Webster <pwebster>
Component: UIAssignee: Paul Webster <pwebster>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, emoffatt, Mike_Wilson, remy.suen
Version: 1.0   
Target Milestone: 1.0 RC0   
Hardware: PC   
OS: Linux   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=536297
Whiteboard:

Description Paul Webster CLA 2010-06-18 11:01:30 EDT
Currently, a menu like the Run menu has 8 separators in a row.

We should not draw them.

PW
Comment 1 Paul Webster CLA 2010-06-18 11:03:49 EDT
Phase 1: don't draw seps with visible==false
Released


PW
Comment 2 John Arthorne CLA 2010-06-18 11:22:15 EDT
*** Bug 317196 has been marked as a duplicate of this bug. ***
Comment 3 Paul Webster CLA 2010-06-18 12:15:37 EDT
phase 2: don't add multiple seps with the same name under the same menu
Released

PW
Comment 4 Paul Webster CLA 2010-06-18 12:17:46 EDT
phase 3: don't draw a sep if the next sibling is a sep.

The main problems have been dealt with, we can open new bugs for the corner cases.

PW
Comment 5 Dani Megert CLA 2010-07-05 05:21:27 EDT
I20100701-1105.

Most of the duplicate separators are gone but there's still one in the 'Navigate' menu. Also, the fix might have been too aggressive, see bug 318848.
Comment 6 Dani Megert CLA 2010-07-05 05:23:45 EDT
Sorry, didn't read comment 4. Filed bug 318850 for the remaining issue.