Bugzilla – Full Text Bug Listing
| Summary: | Impossible to set or change key bindings | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] e4 | Reporter: | Dani Megert <daniel_megert> | ||||||||||
| Component: | UI | Assignee: | Paul Webster <pwebster> | ||||||||||
| Status: | VERIFIED FIXED | QA Contact: | Paul Webster <pwebster> | ||||||||||
| Severity: | blocker | ||||||||||||
| Priority: | P3 | CC: | bokowski, deepakazad, henrik, jessev, Mike_Wilson, mlists, remy.suen | ||||||||||
| Version: | 1.0 | ||||||||||||
| Target Milestone: | 4.1 RC1 | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Windows XP | ||||||||||||
| Whiteboard: | |||||||||||||
| Bug Depends on: | 335985 | ||||||||||||
| Bug Blocks: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Dani Megert
The 'Keys' page should be removed from 4.0 if this can't be fixed. I'd be very close to arguing that being unable to change key bindings is a stop ship. If we are not going to have this capability, then in addition to removing the page, we need to have a clear, well-written blog post (that should probably become part of the readme) that describes the fact that we _intend_to_provide_ this capability, but didn't get there in time for 4.0. It should also include an accurate description of why the old code didn't work (i.e. the old code better not be just calling API!) and how it will be done in the 4.0 world. Q: Can keybindings be changed with the model tooling? Created attachment 173891 [details]
Keep binding service up to date v01
We need to propagate changes from our model to the e4 binding service.
PW
Phase 1 released - remove the prefs page. PW Created attachment 174304 [details] Let the model drive commands and keybindings v02 This is the commands portion, I need to incorporate attachment #173891 [details] still PW Created attachment 174442 [details]
binding service updates v03
Changes from the live model editor get reflected in the binding service ... but unfortunately, to quickly (all the attributes change).
PW
Created attachment 174494 [details]
binding service updates v04
This is decent BindingPersistence -> model -> EBindingService. You can use the live model editor to add simple keybindings.
1) the commands disappear over a restart, leaving the bindings with no command. This is one of the general problems we have with Workbench converting plugin.xml to model, we have to remove it on shutdown, save the deltas, and then add it back and apply the deltas. But because the workbench often starts late, it is included in deltas calculations instead of being part of the pre-loaded model.
2) parameters are hard to do in the live model editor. We don't provide the equivalent of org.eclipse.core.commands.IParameterValues (which in the case of something like Show View is a contribution object that can return live information).
PW
Not being able to edit key bindings is a blocker if we assume 4.1 should be the successor of 3.x. It now partially works but there are still bugs with it, see bug 344181 and bug 344182. This is now resolved. The Compatibility layer reads and edits the 3.x bindings, and creates/deletes the model for the runtime system. We will continue to open bugs for specific failure cases. PW Verified in 4.1 build: I20110515-0800. |