Bugzilla – Full Text Bug Listing
| Summary: | Server view should call refreshServerContent() when server state changes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP ServerTools | Reporter: | Danny Ju <danny.ju> | ||||||
| Component: | jst.server | Assignee: | Angel Vera <arvera> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | Angel Vera <arvera> | ||||||
| Severity: | major | ||||||||
| Priority: | P2 | CC: | david_williams, konstantin | ||||||
| Version: | unspecified | ||||||||
| Target Milestone: | 3.2.2 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| See Also: | https://git.eclipse.org/r/108983 | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
Created attachment 172177 [details]
Proposed patch
Created attachment 172178 [details]
Change was commented out in last patch
With the proposed patch ready for review, we'd like this be fixed in Helios SR1 if possible. Bumping the severity to major as this is currently preventing us from integrating our content into the server view. Looking into the patch, now. I got to do some investigation regarding async call that is occuring inside of refreshServerContent(server). There is some recent information that I have learned where it is possible to call deadlocks in some situations when using async calls. David, I am adding you as a FYI. This one might be coming down for 3.2.1, if I understand what Danny refers as Helios SR1 and assuming there is a full PMC approval and that I don't see much of a risk after the concerns on comment #5 After talking to David, it seems that we are not allowing 3.2.1 changes any longer. Thus, this will have to wait until 3.2.2. changes committed to 32M Changes committed and released to 32M and HEAD(3.3) Fixed. New Gerrit change created: https://git.eclipse.org/r/108983 |
Build Identifier: I20100527-1700 We are extending Server View with a common-navigation-viewer. <extension point="org.eclipse.ui.navigator.viewer"> <viewerContentBinding viewerId="org.eclipse.wst.server.ui.ServersView"> <includes> <contentExtension pattern="oracle.eclipse.tools.weblogic.server.ui.ServersView.content.mbean"> </contentExtension> </includes> </viewerContentBinding> </extension> The content of the viewer is retrieved from server when server is started and is expected to be removed from UI when server starts. It didn't seems to work in current version of Server View. Specificly the viwer is not getting refreshed when server stops. Debugging into the Server View source code, I believe a refreshServerContent() is missing in the server state change listener. (Proposed patch to follow) Reproducible: Always Steps to Reproduce: 1. Extend org.eclipse.ui.navigator.navigatorContent 2. Extend org.eclipse.ui.navigator.viewer and hook up into Server View 3. Start/Stop server and notice viewer not getting refreshed.