Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 317217

Summary: IDisassemblyBackend.SetDebugContextResult frame-level field is extraneous
Product: [Tools] CDT Reporter: John Cortell <john.cortell>
Component: cdt-debugAssignee: cdt-debug-inbox <cdt-debug-inbox>
Status: RESOLVED FIXED QA Contact: Ken Ryall <ken.ryall>
Severity: normal    
Priority: P3 CC: aleherb+eclipse, pawel.1.piech
Version: 7.0Flags: aleherb+eclipse: review+
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Fix john.cortell: iplog-

Description John Cortell CLA 2010-06-17 12:39:22 EDT
IDisassemblyBackend.SetDebugContextResult has a frame-level field that may have been used at some point, but then became irrelevant. The type is internal, so I'd like to clean this up on HEAD.
Comment 1 John Cortell CLA 2010-06-17 12:41:01 EDT
Created attachment 172140 [details]
Fix
Comment 2 John Cortell CLA 2010-06-17 12:41:23 EDT
Toni, please review.
Comment 3 Anton Leherbauer CLA 2010-06-18 02:56:44 EDT
Less code is always +1 ;-)
Comment 4 John Cortell CLA 2010-06-18 11:47:14 EDT
Committed to HEAD and cdt_7_0
Comment 5 CDT Genie CLA 2010-06-18 12:38:12 EDT
*** cdt cvs genie on behalf of jcortell ***
Bug 317217: IDisassemblyBackend.SetDebugContextResult frame-level field is extraneous

[*] DisassemblyBackendDsf.java 1.9 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/DisassemblyBackendDsf.java?root=Tools_Project&r1=1.8&r2=1.9

[*] IDisassemblyBackend.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/IDisassemblyBackend.java?root=Tools_Project&r1=1.1&r2=1.2
[*] DisassemblyBackendCdi.java 1.12 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/DisassemblyBackendCdi.java?root=Tools_Project&r1=1.11&r2=1.12

[*] DisassemblyBackendCdi.java 1.10.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/DisassemblyBackendCdi.java?root=Tools_Project&r1=1.10.2.1&r2=1.10.2.2

[*] IDisassemblyBackend.java 1.1.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/IDisassemblyBackend.java?root=Tools_Project&r1=1.1&r2=1.1.2.1

[*] DisassemblyBackendDsf.java 1.8.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/DisassemblyBackendDsf.java?root=Tools_Project&r1=1.8&r2=1.8.2.1