Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 317209

Summary: JSP Discoverer : not the same originalFilePath on Page elements
Product: [Modeling] MoDisco Reporter: Fabien Giquel <fabien.giquel>
Component: TechnologiesAssignee: Fabien Giquel <fabien.giquel>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: hugo.bruneliere, modisco.web-inbox, nicolas.guyomar
Version: 0.9.0Flags: fabien.giquel: indigo+
Target Milestone: 0.9.0 M1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
JSP metamodel completing with name field
fabien.giquel: iplog+
jsp discoverer patch for originalFilePath field fabien.giquel: iplog+

Description Fabien Giquel CLA 2010-06-17 11:51:43 EDT 
Using the JSP discoverer on one single ".jsp" file, the Page element will have a "originalFilePath" relative to the project.
Using the JSP discoverer on a Java project containing ".jsp" files, the Page elements have a "originalFilePath" simply equal to the .jsp file name.

It would be better to have in both cases an "originalFilePath" relative to the project (excluding "project" name) for following reasons :
- to have the same behavior than the Java Discoverer
- to facilitate JSP generation back targeting another workspace project.
Comment 1 Nicolas Guyomar CLA 2010-06-21 11:23:06 EDT 
Hi Fabien,

The 3 ways of discovering a JSP file result have the same behaviour now.
I have added a field "name" to the EClass "Page" to store the project relative location, "originalFilePath" still stands for the absolute location on the disk

Please find attached 2 patches to apply those modifications


1. I, Nicolas Guyomar, and others contributors listed in this bug, authored
100% of the content
2. I have the rights to donate the content to Eclipse under the EPL
3. I have already provided the filled Employer Consent Forms to the Foundation


Regards
Nicolas
Comment 2 Nicolas Guyomar CLA 2010-06-21 11:23:41 EDT 
Created attachment 172338 [details]
JSP metamodel completing with name field

Add a field "name" to the EClass "Page"
Comment 3 Nicolas Guyomar CLA 2010-06-21 11:24:42 EDT 
Created attachment 172339 [details]
jsp discoverer patch for originalFilePath field

Fix the behaviour of JSP discoverer concerning absolute and relative path of discovered pages
Comment 4 Fabien Giquel CLA 2010-06-21 12:03:46 EDT 
Thanks for your contribution,

The patch has been commited into SVN.

Fabien.
Comment 5 Hugo Bruneliere CLA 2010-10-04 13:44:12 EDT 
The patch has been successfully applied.