Bug 317208

Comment 1 Remy Suen 2011-01-13 12:45:26 EST

Added a 'Close' menu item for minimized views.

Comment 2 Dani Megert 2011-11-07 09:51:24 EST

This is still a major stopper for me.

Comment 3 Paul Webster 2011-12-19 11:17:07 EST

*** Bug 367004 has been marked as a duplicate of this bug. ***

Comment 4 Paul Webster 2012-02-24 07:29:26 EST

OK, so the menu items that are still missing on the context menu for a minimized view are:

- set the orientation (horizontal/vertical, one has to manually size the view now)
- New Fast View (open a new view into the minimized stack)

PW

Comment 5 Dani Megert 2012-02-29 08:59:11 EST

(In reply to comment #4)
> OK, so the menu items that are still missing on the context menu for a
> minimized view are:
> 
> - set the orientation (horizontal/vertical, one has to manually size the view
> now)
> - New Fast View (open a new view into the minimized stack)
> 
> PW

And on that I often use:
[x] Fast View
which allows me to switch the fast view back into its original state. You may now say, that there's an icon which does that, but that's not true: that icon works on all fast views in its trim.

Comment 6 Curtis Windatt 2012-10-18 16:28:58 EDT

A context menu with close, restore and orientation items has been added when the view is minimized on bug 312707.

The menu should also be available in the view trim when in 'fast view' mode (opening a minimized view without restoring the stack).

Comment 7 Curtis Windatt 2012-10-18 17:40:49 EDT

(In reply to comment #6)
> The menu should also be available in the view trim when in 'fast view' mode
> (opening a minimized view without restoring the stack).

This will be more work than I expected.  We would need to be able to contribute menu items to the trim menu in StackRenderer (which currently disposes and recreates all of its items on menu open).  Perhaps we can tag the trim menu the same way we do the view menu (TAG_VIEW_MENU) and do a model lookup in the MinMaxAddon.

Comment 8 Dani Megert 2012-10-19 02:54:28 EDT

(In reply to comment #6)
> A context menu with close, restore and orientation items has been added when
> the view is minimized on bug 312707.

Bug 317207 that is.

Comment 9 Paul Webster 2012-10-19 07:09:40 EDT

(In reply to comment #7)
> This will be more work than I expected.  We would need to be able to
> contribute menu items to the trim menu in StackRenderer (which currently
> disposes and recreates all of its items on menu open).  Perhaps we can tag
> the trim menu the same way we do the view menu (TAG_VIEW_MENU) and do a
> model lookup in the MinMaxAddon.

We need the ability to model a menu on an MPartStack so that it can be saved and rendered.

PW

Comment 10 Piotr Aniola 2013-01-09 11:41:59 EST

in DnDInfo.getModelElement(Control ctrl), there is the following code:

if (modelService.getTopLevelWindowFor(element) == topLevelWindow)
    return element;
return null;

It checkes whether the drop window is the same as current window. 
Disabling the condition makes the drop work on other windows as well.

I will have to test that (and also make sure that views are still prohibited from being dropped to another window) and then I will submit a patch.

Comment 11 Piotr Aniola 2013-01-10 10:49:31 EST

oops, I commented in the wrong bug

Comment 12 Markus Keller 2013-05-07 06:05:56 EDT

I20130502-0800: The Orientation and Restore item are available in the context menu on a minimized view and they work both when the view is visible or minimized. The Close menu item is also there but doesn't work: bug 407377.

Comment 13 Dani Megert 2014-07-08 08:15:51 EDT

This has been fixed during 4.3.