Bugzilla – Full Text Bug Listing
| Summary: | key assist (Ctrl+Shift+L) does not work | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] e4 | Reporter: | Dani Megert <daniel_megert> | ||||||||
| Component: | UI | Assignee: | Jesse <jessev> | ||||||||
| Status: | VERIFIED FIXED | QA Contact: | Paul Webster <pwebster> | ||||||||
| Severity: | major | ||||||||||
| Priority: | P3 | CC: | bokowski, kitlo, Lars.Vogel, mlists, pwebster, remy.suen, thatnitind | ||||||||
| Version: | 1.0 | ||||||||||
| Target Milestone: | 4.1 RC1 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows XP | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Dani Megert
Created attachment 174511 [details]
Work in Progress ... keyAssist v01
*** Bug 332213 has been marked as a duplicate of this bug. *** Jesse, have a look at the key assist dialog. You need a couple of things: 1) to support in in e4, there needs to be some way to hook into org.eclipse.e4.ui.bindings.keys.KeyBindingDispatcher. See org.eclipse.ui.internal.keys.WorkbenchKeyboard in your 3.7 workspace. We can create a KeyAssistDialog in org.eclipse.e4.ui.bindings. Or enhance org.eclipse.e4.ui.bindings.keys.KeyBindingDispatcher to be able to use a dialog contributed from somewhere else, where that somewhere else is the compatibility layer. 2) you need to be able to open the dialog with the list of active keybindings. Once that works, then we need: 3) you need to be able to ask the EBindingService (runtime) if there are any conflicts. That implies we need to be able to store conflicts in one BindingTable. We also need to be able to report conflicts from 2 binding tables at the same context level (i.e. 2 sibling contexts, see org.eclipse.e4.ui.bindings.internal.ContextSet for a definition of level). 4) if there are conflicts, we need to be able to open the key assist dialog with the short list. PW *** Bug 340320 has been marked as a duplicate of this bug. *** Created attachment 194395 [details]
keyAssist v02
Created attachment 195417 [details]
keyAssist v03
Slight cleanup of patch.
PW
(In reply to comment #6) > Created attachment 195417 [details] > keyAssist v03 > Released. Thanx Jesse! PW Verified in 4.1 build: I20110515-0800: it only works partially: while I can bring up the dialog now, I cannot go to the preference page from there via Ctrl+Shift+L anymore. The hint is also missing. Filed bug 345916 to track that. There's also bug 345946. |