Bugzilla – Full Text Bug Listing
| Summary: | Run/Debug toolbar buttons have no hover | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Dani Megert <daniel_megert> |
| Component: | Debug | Assignee: | Platform-Debug-Inbox <platform-debug-inbox> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | curtis.windatt.public, daniel_megert, darin.eclipse, emoffatt, markus.kell.r, Michael_Rennie, pawel.1.piech, pwebster, remy.suen, susan |
| Version: | 4.0 | ||
| Target Milestone: | 4.2 M7 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
|
Description
Dani Megert
Dani, by "hover" you mean no tooltips, right? >Dani, by "hover" you mean no tooltips, right?
Yes.
The renderer was only checking the model for a tooltip. It should be considering the command if it has an associated command. In which build will I be able to verify this? (In reply to comment #4) > In which build will I be able to verify this? When Paul posts the link to the matching 4.0 SDK of last night's build, it should be there. (In reply to comment #5) > When Paul posts the link to the matching 4.0 SDK of last night's build, it > should be there. Or not... It works in my inner but not my outer. I even tried a new workspace for my outer and it didn't work. I'll look at it again on the weekend. Marking as FIXED in I20100618-1748. The (still few) tool items we have now show tooltips... In I20100701-1105 this still does not work for several buttons, e.g. 'Search', all JDT new wizards, Debug buttons, ... In I20100707-2006, I see tooltips for everything except run and debug. (The tooltips do show for search, jdt new wizards, etc.). *** Bug 327037 has been marked as a duplicate of this bug. *** M2 is done... In Juno M3 the tool tip is now shown but it is not dynamic i.e. it does not show the previously launched launch. To see this you need to choose Run/Debug > Launching: [x] Always launch the previously launched application (In reply to comment #13) > In Juno M3 the tool tip is now shown but it is not dynamic i.e. it does not > show the previously launched launch. To see this you need to choose > Run/Debug > Launching: [x] Always launch the previously launched application I can't find the bug but there's another one on this issue. Debug reaches into internals and updates the item labels programmatically. (In reply to comment #14) > (In reply to comment #13) > > In Juno M3 the tool tip is now shown but it is not dynamic i.e. it does not > > show the previously launched launch. To see this you need to choose > > Run/Debug > Launching: [x] Always launch the previously launched application > > I can't find the bug but there's another one on this issue. See bug 341142 for the details. The gist of the problem is that tool tip changes from AbstractLaunchHistoryAction are being ignored. Aggregate move to M5. Retarget to a different milestone if you wish... (In reply to comment #16) > Aggregate move to M5. Retarget to a different milestone if you wish... see comment 17 on bug 341142 - once debug calls back to CommandActionLegacyWrapper#setToolTipText nothing seems to be updated. I created my github branch for this bug: https://github.com/mrennie/eclipse.platform.ui/tree/mrennie/bug/317182 (In reply to comment #18) > I created my github branch for this bug: > > https://github.com/mrennie/eclipse.platform.ui/tree/mrennie/bug/317182 Is there anything to look at in this bug? If not, that's OK (just working through the backlog). PW (In reply to comment #13) > In Juno M3 the tool tip is now shown but it is not dynamic i.e. it does not > show the previously launched launch. To see this you need to choose > Run/Debug > Launching: [x] Always launch the previously launched application I think this is not a new problem but bug 211792. I'm fine closing this as FIXED. (In reply to comment #19) > Is there anything to look at in this bug? If not, that's OK (just working > through the backlog). > > PW Unless there have been any code changes to make CommandActionLegacyWrapper#setToolTipText work, then yes this is still a problem. When last I was looking at this issue, our call to #setToolTip on the action would no-op in CommandActionLegacyWrapper#setToolTipText. (In reply to comment #21) > (In reply to comment #19) > > Is there anything to look at in this bug? If not, that's OK (just working > > through the backlog). > > > > PW > > Unless there have been any code changes to make > CommandActionLegacyWrapper#setToolTipText work, then yes this is still a > problem. When last I was looking at this issue, our call to #setToolTip on the > action would no-op in CommandActionLegacyWrapper#setToolTipText. Stepping through the new code (from Paul's legacyActions branch) shows that the tooltips are being updated (OK) but it seems that after a few different selections the actual shown tooltip gets out of sync with what the selection is. Steps; 1. create Java class with a main - call it 'Clazz' 2. open the Java source from 1. hover over the run toolitem - should read 'Run Clazz.java' 3. launch the class from 2. - should get config named 'Clazz' 4. create some other conifg type named 'Test1' - launch it 5. select editor from 2., and hover over run button - tooltip should say 'Run Clazz' 6. select an entry in the problems view and hover over the run button - should say 'Run Test1' It appears that the labels all get updated on every change as long as you hover over the external tools toolbar button first and then look at the run or debug ones. Paul, is there some code that makes the run / debug special? (In reply to comment #22) > > Paul, is there some code that makes the run / debug special? It appears now the debug and run actions are part of the coolbar: 'org.eclipse.debug.ui.launch.toolbar' rather than the 'org.eclipse.debug.ui.launchActionSet' action set like they used to be. Looks like the fix to bug 361448 changed the toolbar path from 'debug' to 'org.eclipse.debug.ui.launch.toolbar/launchGroup'. If I revert the change to the toolbar path for the run and debug dropdowns the tool tips update as expected. Moving back to platform Debug. The action s changes got things rolling, but the remainder of the fix if there, with the revert for the toolbar path on the run / debug drop-downs. pushed changes to the toolbar path: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=9b7d1174648b6eb56a05672808e4d3ef0fee3e94 |