Bugzilla – Full Text Bug Listing
|
Description
Marc Khouzam
I've added instructions to our WIKI on how to make a project warning-intolerant. http://wiki.eclipse.org/CDT/policy#Eclipse_Java_Errors.2FWarnings Created attachment 208787 [details]
Add missing @Override for Java 6 in dsf.gdb
Now that we are using Java 6, there is a warning when a implemented interface method does not have the @Override annotation.
This patch fixes them for dsf.gdb
Committed to master
Created attachment 208788 [details]
Add missing @Override for Java 6 in dsf.gdb.ui
And this patch is for the missing @Override for dsf.gdb.ui
Committed to master
Created attachment 208976 [details]
More missing @Override for Java 6
Committed to master.
Created attachment 214324 [details]
Add friends for internal packages
Some of the CDT internal stuff was not explicitly allowing other CDT code to use it as a x-friend. This patch add the ones for DSF/DSF-GDB.
I will commit this to master right away as it is a minor fix.
(In reply to comment #5) > Created attachment 214324 [details] > Add friends for internal packages > > Some of the CDT internal stuff was not explicitly allowing other CDT code to > use it as a x-friend. This patch add the ones for DSF/DSF-GDB. > > I will commit this to master right away as it is a minor fix. Mikhail, this fix was in response to your comment about the "Discouraged access" warnings for the internal Tracepoint code. I fixed all "Discouraged access" warnings for DSF/DSF-GDB with this fix. I pushed a small cleanup to remove some @SupressWarnings and instead properly fixed the warnings. https://git.eclipse.org/r/5945 I'll commit to master. (In reply to comment #7) > I pushed a small cleanup to remove some @SupressWarnings and instead properly > fixed the warnings. > https://git.eclipse.org/r/5945 > I'll commit to master. Marc, a FYI. You can configure a PDE project so that warnings won't creep back in (by forcing the warnings to be reported as errors). I set up various CDT projects this way. I documented the steps on the CDT wiki a while back: http://wiki.eclipse.org/CDT/policy#Eclipse_Java_Errors.2FWarnings (In reply to comment #8) > Marc, a FYI. You can configure a PDE project so that warnings won't creep back > in (by forcing the warnings to be reported as errors). I set up various CDT > projects this way. > > I documented the steps on the CDT wiki a while back: > http://wiki.eclipse.org/CDT/policy#Eclipse_Java_Errors.2FWarnings I've been aiming for this for a while, but I haven't fixed all warnings of the DSF/DSF-GDB plugins yet. Maybe soon after Juno. And then I'll do what you recommend. *** cdt git genie on behalf of Marc Khouzam ***
Bug 317173: Cleanup warnings for DSF-GDB.
[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=6abf9e1a4231252f06587bb0f2de002057e293ad
New Gerrit change created: https://git.eclipse.org/r/50010 Gerrit change https://git.eclipse.org/r/50010 was merged to [master]. Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=26bef5d3212c24dca5fc5ff0816728f59c247bbf New Gerrit change created: https://git.eclipse.org/r/50025 Gerrit change https://git.eclipse.org/r/50025 was merged to [master]. Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=d997a7c313290dfcdcab5ff382435950ff620e03 New Gerrit change created: https://git.eclipse.org/r/50136 Gerrit change https://git.eclipse.org/r/50136 was merged to [master]. Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=101150268730e7400354c972ad09eec6d3de1bfc |