Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 317120

Summary:

[NLS] DependencyGraphImpl can cause deadlock

Product:

[WebTools] WTP Java EE Tools

Reporter:

Jason Sholl <jsholl>

Component:

jst.j2ee

Assignee:

Jason Sholl <jsholl>

Status:

RESOLVED FIXED

QA Contact:

Chuck Bridgham <cbridgha>

Severity:

normal

Priority:

CC:

ccc, david_williams

Version:

3.2

Flags:

david_williams: pmc_approved+
jsholl: pmc_approved? (raghunathan.srinivasan)
jsholl: pmc_approved? (naci.dai)
jsholl: pmc_approved? (deboer)
jsholl: pmc_approved? (neil.hauge)
jsholl: pmc_approved? (kaloyan)
cbridgha: review+

Target Milestone:

3.2.1

Hardware:

OS:

Windows Server 2003

Whiteboard:

PMC_approved

Attachments:

Description	Flags
patch for 3.2.1	none

Description Jason Sholl

2010-06-16 17:37:11 EDT

This is follow on work to bug 302644.

The attached patch redesigns the DependencyGraph to only consider raw dependencies, i.e. those that are hard coded in the .settings/org.eclipse.wst.common.component file.  The greatly simplifies the architecture and will completely eliminate deadlocks like those found in 302644.

Comment 1 Jason Sholl

2010-06-16 17:38:41 EDT

Created attachment 172078 [details]
patch for 3.2.1

Comment 2 Chuck Bridgham

2010-06-16 17:54:06 EDT

approve

Comment 3 Jason Sholl

2010-06-21 14:53:00 EDT

Requesting PMC approval for the following three strings.  These strings were previously burned into the code and would be displayed to the user in English only.  Now, they can be translated.

WAITING=Waiting
JOB_NAME=Graph Update
NOTIFICATION_JOB_NAME=Graph Update Notification

Comment 4 Jason Sholl

2010-06-22 14:23:46 EDT

code checked into head for WTP 3.2.1