Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 317106

Summary:	Four example bundles missing required "legal" files (about.html)
Product:	[Tools] GEF	Reporter:	Anthony Hunter <ahunter.eclipse>
Component:	GEF-Legacy GEF (MVC)	Assignee:	Anthony Hunter <ahunter.eclipse>
Status:	RESOLVED FIXED	QA Contact:
Severity:	blocker
Priority:	P3	CC:	david_williams, irbull
Version:	3.6
Target Milestone:	3.6.0 (Helios) RC4
Hardware:	PC
OS:	Linux
Whiteboard:
Bug Depends on:
Bug Blocks:	316720

Description Anthony Hunter

2010-06-16 15:06:44 EDT

From Wayne:
> For
> org.eclipse.gef.examples.flow.source_3.6.0.v20100519-2050.jar
> No  about.html in
> org.eclipse.gef.examples.logic.source_3.6.0.v20100519-2050.jar
> No  about.html in
> org.eclipse.gef.examples.shapes.source_3.6.0.v20100519-2050.jar
> No  about.html in org.eclipse.gef.examples.text.source_3.6.0.v20100519-2050.jar
> 
> Not an excuse, but I looked and last year these four GEF source bundles were
> also missing the about.html. I would rather not try to fix the build now and
> introduce issues in a stable GEF driver we have been testing for three weeks
> just for example source code.
> 
> Can we not fix this in SR1?

I have to admit that I'm inclined to dismiss the issue because they're "just
examples". However, regardless of the nature of the bundles, they are still
subject to the terms of the Eclipse IP Policy and need to be fixed before I can
allow GEF to release.

Sorry.

------------------

So four GEF example plug-ins are blocking the entire Helios release.

I looked in the source, for whatever reason, we are using:
generate.plugin@org.eclipse.gef.examples...
Rather than
generate.feature@org.eclipse.gef.examples...
Like every other feature in Modeling that I have.

It has been generate.plugin@ for the entire history of GEF, so not sure when the about.html started disappearing. It was not there in Galileo and nobody noticed.

I am going to change the feature.xml and the supporting build files to fix this.

Comment 1 David Williams

2010-06-16 16:14:05 EDT

don't forget about zest? 

Missing about.html in file: org.eclipse.zest.layouts.source_1.1.0.v20100519-2050.jar

Comment 2 Anthony Hunter

2010-06-16 16:32:11 EDT

(In reply to comment #1)
> don't forget about zest? 
> 
> Missing about.html in file:
> org.eclipse.zest.layouts.source_1.1.0.v20100519-2050.jar

OK, I tried a few things and got the examples fixed, will need to do the same with this bundle.

Comment 3 Anthony Hunter

2010-06-16 17:07:33 EDT

Fixed the bundles and the release build has been re-promoted as R201006161000 . It is still hidden.

I have updated the Helios gef.build file.

Comment 4 Ian Bull

2010-06-16 17:50:34 EDT

Thanks Anthony. I'm always late to this build parties. :-)

Comment 5 Anthony Hunter

2010-06-16 18:35:43 EDT

I had to explicitly add about.html to the src.includes for zest.layouts build.properties to fix the problem. 

By the way, I did a diff between draw2d and zest features, plugins, build.properties, bla, bla, bla and everything was the same. But somehow zest.layouts needed this magical fix to work.

Very frustrating that the builds are constantly this fragile.