Bugzilla – Full Text Bug Listing
| Summary: | [EditorMgmt] Recursive editor activation when using AbstractMultiEditor | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Samantha Chan <chanskw> | ||||||
| Component: | UI | Assignee: | Remy Suen <remy.suen> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | Remy Suen <remy.suen> | ||||||
| Severity: | major | ||||||||
| Priority: | P3 | CC: | bokowski, nikolaybotev.b, pwebster | ||||||
| Version: | 3.6 | ||||||||
| Target Milestone: | 3.7 M6 | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Samantha Chan
Is it possible to consider this for 3.6.1? (In reply to comment #0) > 1) Create an multi pane editor implmentation based on AbstractMultiEditor. If you subclass MultiEditor instead, does the problem go away? (In reply to comment #2) > (In reply to comment #0) > > 1) Create an multi pane editor implmentation based on AbstractMultiEditor. > > If you subclass MultiEditor instead, does the problem go away? Sorry, I am not able to subclass to MultiEditor as my editor won't work based on other problems I have encounted with the MultiEditor. That's why I went with subclassing from AbstractMultiEditor. Can you please let me know what this exception really means, and what is the effect of this exception? Can this exception be omitted? If this exception indicates a major problem, any chance of fixing this in 3.6.2? Created attachment 184885 [details] AbstractMultiEditor recursive activation patch v1 (In reply to comment #3) > Can you please let me know what this exception really means, and what is the > effect of this exception? Can this exception be omitted? The gist of it is that while trying to activate inner editor B that has been selected, we try to grant focus to the part's pane. The pane that is returned is the outer editor's pane. So the code flows into an activation request again (whilst granting focus to the part's pane), since the other inner editor hasn't been activated yet, we still think the inner editor A is the active editor so we try to make it the active part. At this point, we detect an activation request on inner editor A whilst attempting to activate inner editor B and print a warning message into the logs. > If this exception indicates a major problem, any chance of fixing this in > 3.6.2? Since Eclipse stays up, it is not really a huge problem although constantly printing stuff in the logs does make us look pretty bad. We will first have to assess the impact of this (or any other potential) fix before we can make a call here. Boris, this is the recursive activation bug I talked to you about. (In reply to comment #4) > Created an attachment (id=184885) [details] > AbstractMultiEditor recursive activation patch v1 Just a comment, this fix is way to risky for a maintenance release. It would have to be tested in 3.7 for at least one full milestone first (and that will miss the 3.6.2 window). PW (In reply to comment #6) > (In reply to comment #4) > > Created an attachment (id=184885) [details] [details] > > AbstractMultiEditor recursive activation patch v1 > > > Just a comment, this fix is way to risky for a maintenance release. It would > have to be tested in 3.7 for at least one full milestone first (and that will > miss the 3.6.2 window). > > PW Thanks so much... what problems would I encounter if this is not fixed? Other than having lots of errors logged? (In reply to comment #7) > Thanks so much... what problems would I encounter if this is not fixed? Other > than having lots of errors logged? From a cursory glance I don't have any reason to believe that there are any adverse side effects to this recursive activation request. Thanks! *** Bug 241624 has been marked as a duplicate of this bug. *** Created attachment 188052 [details] AbstractMultiEditor recursive activation patch v2 Attachment 184885 [details] with a unit test for validation. (In reply to comment #11) > Created attachment 188052 [details] > AbstractMultiEditor recursive activation patch v2 Patch released to CVS HEAD. Thanks for the bug report, Samantha! Verified by testing an inner with an editor that extends AbstractMultiEditor on Windows XP with I20110307-2110. |