Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 317101

Summary: [NLS] Display issues and missing help ids in the 'Deployment Assembly' preference page
Product: [WebTools] WTP Java EE Tools Reporter: Aidyl Kareh <amkareh>
Component: jst.j2eeAssignee: Aidyl Kareh <amkareh>
Status: RESOLVED FIXED QA Contact: Chuck Bridgham <cbridgha>
Severity: normal    
Priority: P3 CC: amkareh, ccc, kaloyan
Version: 3.2Flags: amkareh: pmc_approved? (david_williams)
amkareh: pmc_approved? (raghunathan.srinivasan)
amkareh: pmc_approved? (naci.dai)
amkareh: pmc_approved? (deboer)
amkareh: pmc_approved? (neil.hauge)
kaloyan: pmc_approved+
cbridgha: review+
Target Milestone: 3.2.1   
Hardware: PC   
OS: Windows Vista   
Whiteboard: PMC_approved
Attachments:
Description Flags
Proposed patch ccc: iplog+

Description Aidyl Kareh CLA 2010-06-16 14:35:28 EDT 
Build Identifier: WTP 3.2

I saw several issues in the 'Deployment Assembly' page:
1) Infopop ids need to be defined for the 'Deployment Assembly' page tabs and the new reference wizards.
2) Each time the user clicks or modifies the 'Deploy Path' column, the whole table is refreshed instead of just the row. This causes the icons to blink.
3) In the 'New Reference Wizard', when adding an 'Archive' reference, the 'Browse...' button opens a window called 'JAR Selection'. For consistency, this window should be called 'Archive Selection'.
4) If multiple verifiers are defined and one of them has a warning/error, then the AddModuleDependenciesPropertiesPage.getMessage() appends all messages without taking into consideration that some can be 'OK'.

Reproducible: Always
Comment 1 Aidyl Kareh CLA 2010-06-16 14:38:12 EDT 
Created attachment 172066 [details]
Proposed patch

Patch fixes all the issues mentioned in the description.
Comment 2 Chuck Bridgham CLA 2010-06-16 18:00:01 EDT 
approve
Comment 3 Carl Anderson CLA 2010-06-21 12:12:25 EDT 
Adding NLS tag, since there is one new string added.
Comment 4 Aidyl Kareh CLA 2010-06-21 15:11:59 EDT 
    * Explain why you believe this is a stop-ship defect. Or, if it is a
"hotbug" (requested by an adopter) please document it as such. 

This patch fixes several issues (See Description) and when doing so had to add a new description string for the 'Archive Selection' wizard.

    * Is there a work-around? If so, why do you believe the work-around is
insufficient? 

No.

    * How has the fix been tested? Is there a test case attached to the
bugzilla record? Has a JUnit Test been added? 

Tested through UI.

    * Give a brief technical overview. Who has reviewed this fix? 

This patch fixes some inconsistencies where the add 'Archive' reference wizard on the Deployment Assembly preference page displays 'Jar' instead of 'Archive'. To achieve this fix a description string was added. This has been reviewed by Chuck.

    * What is the risk associated with this fix? 

None.
Comment 5 Carl Anderson CLA 2010-06-22 12:18:55 EDT 
Committed to HEAD for WTP 3.2.1