Bugzilla – Full Text Bug Listing
| Summary: | [breadcrumb] BreadcrumbItems not disposed when editor closed | ||
|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Markus Keller <markus.kell.r> |
| Component: | Text | Assignee: | Dani Megert <daniel_megert> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | P3 | CC: | daniel_megert, deepakazad, raksha.vasisht |
| Version: | 3.6 | Keywords: | performance |
| Target Milestone: | 3.6.1 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 317283 | ||
Filed bug 317283 for Debug and bug 317282 for another leak. Fixed in HEAD. Fix is in BreadcrumbViewer.java rev. 1.28. Fixed in R3_6_maintenance. Available in builds >= M20100714-0800. Verified with M20100728-0800 on WinXp. Verified for 3.7 M1 with I20100802-1800. |
HEAD BreadcrumbItems are leaked (not disposed) when a Java editor is closed. Found that by adding the following to org.eclipse.swt.widgets.Widget: // --- Find undisposed widgets: --- private Error creation; { creation = new Error("Widget not disposed before finalized! Created at:"); } protected void finalize() throws Throwable { if (!isDisposed()) { creation.printStackTrace(); } } //--- End find undisposed widgets. --- From looking at the code, I think there are more leaks in the breadcrumb: BreadcrumbViewer does not extend handleDispose(), never disposes of the fToolTipLabelProvider (which installs global listeners), etc.