Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 317016

Summary: Typo in org.eclipse.cdt.codan.core.CodanRuntime#getChechersRegistry()
Product: [Tools] CDT Reporter: Meisam <meisam.fathi>
Component: cdt-codanAssignee: Elena Laskavaia <elaskavaia.cdt>
Status: RESOLVED FIXED QA Contact: Elena Laskavaia <elaskavaia.cdt>
Severity: normal    
Priority: P3 CC: cdtdoug
Version: 7.0   
Target Milestone: 8.0   
Hardware: PC   
OS: Linux   
Whiteboard:

Description Meisam CLA 2010-06-16 05:16:20 EDT
getCheckersRegistry() makes more sense.
Comment 1 Elena Laskavaia CLA 2010-06-16 09:50:35 EDT
yeah. And problem is that it is an API
Comment 2 Meisam CLA 2010-06-16 10:21:03 EDT
I have found some other typos, too. But they were inside comments. Should I report them, too?
Comment 3 Elena Laskavaia CLA 2010-06-16 10:47:30 EDT
sure. Separate bug. One for all comments.
Comment 4 Elena Laskavaia CLA 2010-06-16 21:02:39 EDT
fixed on head. 
Btw how do you find all these do you have special spell checker for class/function names?
Comment 5 CDT Genie CLA 2010-06-16 21:23:13 EDT
*** cdt cvs genie on behalf of elaskavaia ***
Bug 317016: renamed miss-spelled function

[*] CodanMarkerProblemReporter.java 1.16 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.core/src/org/eclipse/cdt/codan/internal/core/model/CodanMarkerProblemReporter.java?root=Tools_Project&r1=1.15&r2=1.16

[*] AbstractCheckerWithProblemPreferences.java 1.6 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.core/src/org/eclipse/cdt/codan/core/model/AbstractCheckerWithProblemPreferences.java?root=Tools_Project&r1=1.5&r2=1.6

[*] MANIFEST.MF 1.17 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.core/META-INF/MANIFEST.MF?root=Tools_Project&r1=1.16&r2=1.17

[*] CodanRuntime.java 1.7 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.core/src/org/eclipse/cdt/codan/core/CodanRuntime.java?root=Tools_Project&r1=1.6&r2=1.7

[*] CodanPreferencePage.java 1.17 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.ui/src/org/eclipse/cdt/codan/internal/ui/preferences/CodanPreferencePage.java?root=Tools_Project&r1=1.16&r2=1.17

[*] AbstractCodanProblemDetailsProvider.java 1.8 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.ui/src/org/eclipse/cdt/codan/ui/AbstractCodanProblemDetailsProvider.java?root=Tools_Project&r1=1.7&r2=1.8

[*] CheckerTestCase.java 1.14 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.core.test/src/org/eclipse/cdt/codan/core/test/CheckerTestCase.java?root=Tools_Project&r1=1.13&r2=1.14
Comment 6 Meisam CLA 2010-06-17 00:05:12 EDT
No, I found this when I was reviewing the code, but it's a nice idea to have a tool for finding this specific type of typos.

I use some other tools like PDM, FindBugs, and Check Style, too. These tools can detect and report a lot of issues that remain uncaught by programmers, though what they report should be inspected manually. Should I report issues that I detect using these tools, too?
Comment 7 Elena Laskavaia CLA 2010-06-17 09:18:55 EDT
Yes sure, you can maybe put them in the same bug you open for typos in comments. Btw I know what these tools are - Codan is one of them :) For C/C++.
Comment 8 Meisam CLA 2010-06-17 10:11:19 EDT
It might be a better idea to configure hudson to do it. It supports a lot of these tools.
Comment 9 Elena Laskavaia CLA 2010-06-17 10:16:23 EDT
hudson does not support running these tool only parsing output of such tool if they are integrated into the build. Currently they are not.
Comment 10 Meisam CLA 2010-06-17 10:37:16 EDT
It's up to commiters to decide if they want to integrate them to the build process or not.