Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 316975

Summary:

[launcher] memory leak on failure to read launcher.ini file

Product:

[Eclipse Project] Equinox

Reporter:

Andrew Niefer <aniefer>

Component:

Framework

Assignee:

equinox.framework-inbox <equinox.framework-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

mober.at+eclipse, tjwatson

Version:

3.6

Flags:

tjwatson: review+

Target Milestone:

3.6.1

Hardware:

OS:

Linux

Whiteboard:

Bug Depends on:

Bug Blocks:

317195, 322291

Attachments:

Description	Flags
patch	none
patch v1	aniefer: iplog+

Description Andrew Niefer

2010-06-15 16:54:01 EDT

If we fail to read the launcher.ini file for some reason (eg --launcher.ini with bad value), then we leak memory that was allocated as buffers.

Comment 1 Andrew Niefer

2010-06-15 16:55:33 EDT

Created attachment 171994 [details]
patch

Patch extracted from bug 149994

Comment 2 Martin Oberhuber

2010-06-15 18:09:04 EDT

Created attachment 172000 [details]
patch v1

Same patch by me for correct iplog+ tracking in case it gets committed.

I don't think the memory leak is too relevant and I can't quite see the value in splitting this out of the full patch on bug 149994, but here you go if you want to.

Comment 3 Andrew Niefer

2010-06-16 10:46:16 EDT

I split this from the full patch because if 149994 is being considered for 3.6.1 it would be good to have the patch as focused as possible.  There is no reason this can't go in 3.6.1 as well, but I thought it would be better to have them separate.

Comment 4 Andrew Niefer

2010-06-17 11:31:37 EDT

Comment on attachment 172000 [details]
patch v1

This patch was released to 3.7 head in bug 317195

Comment 5 Thomas Watson

2010-08-10 14:23:22 EDT

+1 for 3.6.1.

Comment 6 Andrew Niefer

2010-08-10 15:50:44 EDT

patch released to branch

Comment 7 Andrew Niefer

2010-08-10 15:50:51 EDT