Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 316920

Summary:

[UI]A few dialogs are missing mnemonics

Product:

[WebTools] WTP Source Editing

Reporter:

Valentin Baciu <valentinbaciu>

Component:

wst.xml

Assignee:

Sarika Sinha <sarika.sinha>

Status:

VERIFIED FIXED

QA Contact:

Nitin Dahyabhai <thatnitind>

Severity:

minor

Priority:

CC:

nsand.dev, sarika.sinha

Version:

3.2

Keywords:

accessibility

Target Milestone:

3.3 M1

Flags:

nsand.dev: review+
nsand.dev: review+

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Add DTD dialog	none
Add namespace (alternate)	none
Add namespace	none
Edit namespace	none
Edit namespaces	none
Outline menu	none
Select file dialog	none
XML Files preferences page	none
patch with mnemonics	nsand.dev: iplog+
Mnemonic conflict	none
Two missed mnemonics	none
Table could use a border	none
Patch to add border and change mnemonic	nsand.dev: iplog+

Description Valentin Baciu

2010-06-15 11:02:05 EDT

The following dialogs are missing mnemonics:
- Add DTD information 
- Edit namespaces
- Add and edit namespace info (launched by clicking add and edit from the above dialog)
- Select file (invoked from the browse button in the above dialogs)
- Edit processing instruction
- XML Files preferences page - the label for the suffix combo

Further, the menu entries for the XML outline view (Link with editor, Show Attributes) also need mnemonics.

There may be more. I'm attaching a few screenshots to show the problems.

Comment 1 Valentin Baciu

2010-06-15 11:02:55 EDT

Created attachment 171938 [details]
Add DTD dialog

Comment 2 Valentin Baciu

2010-06-15 11:03:21 EDT

Created attachment 171939 [details]
Add namespace (alternate)

Comment 3 Valentin Baciu

2010-06-15 11:03:42 EDT

Created attachment 171940 [details]
Add namespace

Comment 4 Valentin Baciu

2010-06-15 11:03:53 EDT

Created attachment 171941 [details]
Edit namespace

Comment 5 Valentin Baciu

2010-06-15 11:04:06 EDT

Created attachment 171942 [details]
Edit namespaces

Comment 6 Valentin Baciu

2010-06-15 11:04:20 EDT

Created attachment 171943 [details]
Outline menu

Comment 7 Valentin Baciu

2010-06-15 11:04:35 EDT

Created attachment 171944 [details]
Select file dialog

Comment 8 Valentin Baciu

2010-06-15 11:04:54 EDT

Created attachment 171945 [details]
XML Files preferences page

Comment 9 Sarika Sinha

2010-07-09 05:41:02 EDT

Created attachment 173846 [details]
patch with mnemonics

Have added the mnemonics as per the attachments apart from "Select File Dialog" which uses "Workspace Files" and "Import "Files..." from wst.common as part of SelectXMLCatalogIdPanel.

Comment 10 Nick Sandonato

2010-07-28 16:55:51 EDT

Thank you, Sarika.

Comment 11 Valentin Baciu

2010-08-20 14:02:59 EDT

I verified and most of the issues are addressed. A few however were missed. See the new attachments.

Comment 12 Valentin Baciu

2010-08-20 14:03:27 EDT

Created attachment 177124 [details]
Mnemonic conflict

Comment 13 Valentin Baciu

2010-08-20 14:03:47 EDT

Created attachment 177125 [details]
Two missed mnemonics

Comment 14 Valentin Baciu

2010-08-20 14:04:08 EDT

Created attachment 177126 [details]
Table could use a border

Comment 15 Valentin Baciu

2010-08-20 14:12:29 EDT

Reopening to fix the few missed little things.

Comment 16 Sarika Sinha

2010-08-26 02:19:22 EDT

(In reply to comment #13)
> Created an attachment (id=177125) [details]
> Two missed mnemonics

This is provided by wst.common and hence missing from the patch. (comment 9)

Comment 17 Sarika Sinha

2010-09-08 02:09:39 EDT

Created attachment 178371 [details]
Patch to add border and change mnemonic

Patch adds the border and removes mnemonic conflict.

Comment 18 Nick Sandonato

2010-09-08 15:53:33 EDT

All Source Editor changes have been checked in.

Comment 19 Valentin Baciu

2010-09-09 10:00:24 EDT

Verified with I-3.3.0-20100909025448.