Bug 316879

Description Tim Moore 2010-06-15 06:37:21 EDT

Build Identifier: M20100211-1343

We've been affected by at least two issues in the click event dispatching, which currently does:

notifyTable(SWT.MouseEnter);
notifyTable(SWT.MouseMove);
notifyTable(SWT.Activate);
notifyTable(SWT.FocusIn);
notifyTable(SWT.MouseDown, createMouseEvent(x, y, 1, SWT.BUTTON1, 1));
notifyTable(SWT.MouseUp);
notifyTable(SWT.Selection, createEvent());
notifyTable(SWT.MouseHover);
notifyTable(SWT.MouseMove);
notifyTable(SWT.MouseExit);
notifyTable(SWT.Deactivate);
notifyTable(SWT.FocusOut);

The first issue is that Selection normally occurs immediately after MouseDown, i.e. before MouseUp.
The second issue is that the MouseUp event (at least) should be a proper mouse event with coordinates, button pressed, etc - in the same way as MouseDown.

We believe this is more correct - fixing our specific issue:

notifyTable(SWT.MouseEnter);
notifyTable(SWT.MouseMove);
notifyTable(SWT.Activate);
notifyTable(SWT.FocusIn);
notifyTable(SWT.MouseDown, createMouseEvent(x, y, 1, SWT.BUTTON1, 1));
notifyTable(SWT.Selection, createEvent());
notifyTable(SWT.MouseUp, createMouseEvent(x, y, 1, SWT.BUTTON1, 1));
notifyTable(SWT.MouseHover);
notifyTable(SWT.MouseMove);
notifyTable(SWT.MouseExit);
notifyTable(SWT.Deactivate);
notifyTable(SWT.FocusOut);

As far as we know, other events might require a proper mouse event? - but our code doesn't rely on these at the moment.

Reproducible: Always