Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 316875

Summary:

[backport] Commit, Apply Patch and Synchronize no longer take keybindings

Product:

[Eclipse Project] Platform

Reporter:

Tomasz Zarna <tomasz.zarna>

Component:

Team

Assignee:

Tomasz Zarna <tomasz.zarna>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

fabio.canepa, jschnab, jtk499, malaperle, mauromol

Version:

3.6

Flags:

Szymon.Brandys: review+

Target Milestone:

3.6.1

Hardware:

OS:

All

Whiteboard:

Bug Depends on:

306173, 323481

Bug Blocks:

Attachments:

Description	Flags
Fix v01	none
Fix v02	none
mylyn/context/zip	none

Description Tomasz Zarna

2010-06-15 05:35:54 EDT

+++ This bug was initially created as a clone of Bug #306173 +++

This bug is for backporting the fix for bug 306173 to Eclipse 3.6.1.

Comment 1 Tomasz Zarna

2010-08-12 07:53:07 EDT

Since we're in RC2, I need another committer to review the fix as well as a +1 from Szymon. The additional reviewer can be the component lead since he didn't make the fix.

Comment 2 Tomasz Zarna

2010-08-24 05:20:46 EDT

Created attachment 177291 [details]
Fix v01

Comment 3 Tomasz Zarna

2010-08-24 07:49:32 EDT

Bug 323481 adds a cosmetic change to the fix from bug 306173. We would like to backport both of them.

Comment 4 Tomasz Zarna

2010-08-24 07:52:22 EDT

Created attachment 177303 [details]
Fix v02

Comment 5 Tomasz Zarna

2010-08-24 07:52:24 EDT

Created attachment 177304 [details]
mylyn/context/zip

Comment 6 Szymon Brandys

2010-08-24 07:58:42 EDT

Well, this is the best thing we can do about it at this point :-) +1.

Comment 7 Tomasz Zarna

2010-08-24 08:17:27 EDT

Released to 3.6.x branch.

Comment 8 Tomasz Zarna

2010-09-02 05:09:41 EDT

Verified in M20100901-0800.

Comment 9 Fabio

2010-09-24 08:51:23 EDT

Hi,
I've just updated to version 3.6.1 but the problem is still here...
Is this patch backported to helios SR1 ?

Comment 10 Tomasz Zarna

2010-09-24 09:23:40 EDT

The 3.6.1 is still not available on Eclipse downloads site, could you send the build ID you updated to? Is it higher that the one from comment 8?

Comment 11 Fabio

2010-09-24 09:48:32 EDT

(In reply to comment #10)
> The 3.6.1 is still not available on Eclipse downloads site, could you send the
> build ID you updated to? Is it higher that the one from comment 8?

Well I've done the online update (Help -> Check for update) and my eclipse updated to:
Version: Helios Service Release 1
Build id: 20100917-0705

Comment 12 Tomasz Zarna

2010-09-27 05:22:05 EDT

3.6.1 is *now* available as part of the Helios SR1 release. Please go to http://download.eclipse.org/eclipse/downloads/drops/R-3.6.1-201009090800/index.php and grab it. I've just double checked the fix with that build and it works fine to me.

Comment 13 Fabio

2010-09-27 05:34:13 EDT

(In reply to comment #12)
> 3.6.1 is *now* available as part of the Helios SR1 release. Please go to
> http://download.eclipse.org/eclipse/downloads/drops/R-3.6.1-201009090800/index.php
> and grab it. I've just double checked the fix with that build and it works fine
> to me.

I've done the online update to helios SR1 both on windows and both on linux and I still have the problem: keybinding does not work under subversive.
Is there any difference between update an re-install eclipse ?

Comment 14 Tomasz Zarna

2010-09-27 05:53:26 EDT

This bug is about keybindings for CVS, which required a fix in Team. Broken keys in Subversive is a different story, see bug 309074.

Comment 15 Fabio

2010-09-27 06:55:22 EDT

(In reply to comment #14)
> This bug is about keybindings for CVS, which required a fix in Team. Broken
> keys in Subversive is a different story, see bug 309074.

Ok sorry... On cvs it ok.