Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 316855

Summary: [CSS] Leaking background images
Product: [Eclipse Project] e4 Reporter: Thomas Schindl <tom.schindl>
Component: UIAssignee: Bogdan Gheorghe <gheorghe>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P3 CC: bokowski, gheorghe, john.arthorne, pwebster, remy.suen
Version: 0.9   
Target Milestone: 1.0 RC0   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:

Description Thomas Schindl CLA 2010-06-15 02:56:07 EDT 
Bogdan, I'm not sure why you commented the lines in GradientBackgroundListener where we are disposing the old resource. Too me this looks like a severe ResourceLeak.
Comment 1 Thomas Schindl CLA 2010-06-15 02:57:26 EDT 
The change was introduced with the commit for bug 314157. Can you clarify why you are not disposing of the old image?
Comment 2 Remy Suen CLA 2010-06-15 06:08:24 EDT 
I noticed this last night also.
Comment 3 Thomas Schindl CLA 2010-06-15 16:56:46 EDT 
Bogdan? Should we revert this change?
Comment 4 Bogdan Gheorghe CLA 2010-06-16 17:57:13 EDT 
The code was wrong as it was disposing images that it might have not created (as in the case of inheriting a background image from a parent). I have new code that keeps track of images created by the gradient listener and disposes of them at the proper time. (I checked for resource leaks and with the new code we're down to some jdt editor colors and the view menu image used by the stack renderer which Eric knows about).
Comment 5 Bogdan Gheorghe CLA 2010-06-16 20:22:39 EDT 
Fixed in HEAD > 20100618