Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 316831

Summary: [pull up] pulling up a method changes a method call due to visibility
Product: [Eclipse Project] JDT Reporter: Gustavo Soares <gsoares>
Component: UIAssignee: JDT-UI-Inbox <jdt-ui-inbox>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: markus.kell.r, raksha.vasisht
Version: 3.6   
Target Milestone: ---   
Hardware: PC   
OS: All   
Whiteboard: stalebug

Description Gustavo Soares CLA 2010-06-14 17:08:55 EDT
Build Identifier: 20090920-1017

Apply the pull up method to a method leads to a behavioral change. After the refactoring, a method call refers to a private method.

Reproducible: Always

Steps to Reproduce:
1. Create the classes:

public class A  {
  private int k() {
    return 20; 
  }   
}
public class B extends A {    
  public int k() {
    return 10; 
  }
  public int m() {
    return k();
  }   
  public int test() {
    return m();
  }
}

2. the method test returns 10
3. Apply the pull up method to m():

public class A  {
  private int k() {
    return 20; 
  }
  public int m() {
    return k();
  }       
}
public class B extends A {    
  public int k() {
    return 10; 
  }
  public int test() {
    return m();
  }
}

4. After the refactoring, the method test returns 20.
Comment 1 Eclipse Genie CLA 2020-05-17 17:11:08 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.