Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 316818

Summary:

SecurityIdentityImpl.getDescription() and .setDescription() methods need to be updated

Product:

[WebTools] WTP Java EE Tools

Reporter:

Aidyl Kareh <amkareh>

Component:

jst.j2ee

Assignee:

Aidyl Kareh <amkareh>

Status:

RESOLVED FIXED

QA Contact:

Chuck Bridgham <cbridgha>

Severity:

normal

Priority:

CC:

amkareh, ccc

Version:

unspecified

Flags:

cbridgha: review+

Target Milestone:

3.2.1

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Proposed Patch	none

Description Aidyl Kareh

2010-06-14 15:57:18 EDT

Build Identifier: WTP 3.2

The getDescription() and setDescription() methods in the SecurityIdentityImpl class should get/modify the first 'description' element if multiple description elements are allowed.

Reproducible: Always

Comment 1 Aidyl Kareh

2010-06-14 16:04:48 EDT

Created attachment 171869 [details]
Proposed Patch

Patch updated the getDescription() and setDescription() methods in the SecurityIdentityImpl class to get/modify the first 'description' element if multiple description elements are allowed.

Comment 2 Chuck Bridgham

2010-06-15 21:59:43 EDT

approved

Comment 3 Carl Anderson

2010-06-17 17:10:34 EDT

Committed to HEAD for WTP 3.2.1, but with one minor change:

I replaced the call to String.isEmpty() with String.length() < 1

This is due to the fact that String.isEmpty() is new to Java 6, and WTP is still compiled with/compatible with Java 5.