Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 316714

Summary: Some BREEs missing for Helios common repo bundles
Product: Community Reporter: David Williams <david_williams>
Component: Cross-ProjectAssignee: David Williams <david_williams>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: krum.tsvetkov, matthias.sohn, mknauer, sbouchet, stepper, william.piers
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Bug Depends on: 317514    
Bug Blocks:    
Attachments:
Description Flags
updated data as of 6/14 11 pm eastern
none
updated data as of 6/15 9 am eastern
none
updated data as of 6/17 9 am eastern none

Description David Williams CLA 2010-06-14 01:33:01 EDT
See bug 280221 for similar bug/analysis for last year's Galileo. 

I have rough test that scans through the jars in Helios repository, and looks for BREEs. It also checks in the jar has Java Code or not, since if the jar does not contain java code, a BREE is not required (and, many would say, not recommended since its an unnecessary constraint in that case.). 

The test code I have has no way of determining if a BREE is set to the correct or best value ... just if one is present or not. 

Also, the data I have is only for the common repo copied to /helios/releases (currently staging) it does NOT at this time include those that are left at the "trusted contributions" location (for Eclipse and Equinox). 

Summary: 
 Checked 2776 of 2776.
 Java with BREE: 1687
 Non Java without BREE:976


Distribution of BREEs: 
    4  J2SE-1.3,CDC-1.1/Foundation-1.1
    3  JRE-1.1
    19  J2SE-1.3
    9  JavaSE-1.6
    8  J2SE-1.2
    1342  J2SE-1.5
    1  J2SE-1.3,CDC-1.0/Foundation-1.0
    189  J2SE-1.4
    36  CDC-1.1/Foundation-1.1,J2SE-1.4
    1  J2SE-1.5,J2SE-1.4,CDC-1.0/Foundation-1.0
    37  JavaSE-1.6,J2SE-1.5
    4  J2SE-1.5, JavaSE-1.6
    2  J2SE-1.4,J2SE-1.3
    1  OSGi/Minimum-1.0,CDC-1.0/Foundation-1.0
    3  J2SE-1.4,CDC-1.0/Foundation-1.0,J2SE-1.3
    1  J2SE-1.5,JavaSE-1.6
    1  J2SE-1.5,
    5  J2SE-1.5,J2SE-1.4,CDC-1.1/Foundation-1.1
    15  CDC-1.0/Foundation-1.0,J2SE-1.3
    1  CDC-1.0/Foundation-1.0,J2SE-1.2
    1  CDC-1.1/Foundation-1.1,J2SE-1.3
    1  CDC-1.1/Foundation-1.1,J2SE-1.2
    3  J2SE-1.4,J2SE-1.3,CDC-1.0/Foundation-1.0


Of the following errors, I would not think any are so serious they'd cause problems ... unless some adopter complains. I'm not sure they'd even need to be fixed in maintenance release, if you were not otherwise touching the bundle, But ... next time the bundle is touch for some other reason, just as well fix the BREE too. 


Only 12 java bundles missing a BREE! That's pretty good. Keep in mind, my test may not be perfect. For example, by its name, org.eclipse.emf.doc, does not sounds like it would have code it in but shows up here as if is does? So, the test itself may need some improvement. 

     Java Bundles without BREE: 12
        javax.jws_2.0.0.v201005080400.jar
        javax.xml.bind.swordfish.tooling_0.10.0.v20100609104
        javax.xml.bind_2.0.0.v20080604-1500.jar
        javax.xml.stream.swordfish.tooling_0.10.0.v201006091
        org.apache.commons.cli_1.0.0.v20080604-1500.jar
        org.apache.neethi_2.0.4.1.jar
        org.apache.taglibs.standard.glassfish.source_1.2.0.v
        org.eclipse.emf.cdo.dawn.codegen.dawngenmodel.source
        org.eclipse.emf.doc_2.6.0.v20100607-0756.jar
        org.eclipse.jdt.core.compiler.batch_3.6.0.I20100608-
        org.eclipse.mtj.examples.source_1.1.0.v201006021259.
        org.eclipse.nebula.widgets.compositetable_1.0.0.jar


These non-java bundles with BREEs, IMHO, are less of a problem ... but, 
if you wanted to be pure ... next time you touch the bundle you should consider removing it. (That is, if my test is accurate, and these really are resource only bundles). 


 Non Java Bundles with BREE: 101
   org.eclipse.birt.example_2.6.0.v20100303.jar
   org.eclipse.buckminster.ui.capabilities_1.0.0.r11210.jar
   org.eclipse.draw2d.doc.isv_3.5.0.v20100519-2050.jar
   org.eclipse.ecf.doc_1.3.0.v20100607-0607.jar
   org.eclipse.ecf.ui.capabilities_1.0.0.v20100607-0607.jar
   org.eclipse.egit.doc_0.8.1.jar
   org.eclipse.egit_0.8.1.jar
   org.eclipse.emf.cdo.dawn.sdk_0.2.0.v20100602-1722.jar
   org.eclipse.emf.cdo.sdk_3.0.0.v20100520-0807.jar
   org.eclipse.emf.ecoretools.doc_0.10.0.v20100521-2009.jar
   org.eclipse.emf.mapping.ecore.editor_2.6.0.v20100607-0756.jar
   org.eclipse.emf.mapping.ecore_2.6.0.v20100607-0756.jar
   org.eclipse.emf.mint.doc_0.9.0.v201006092349.jar
   org.eclipse.emf.mwe.doc_1.0.0.v201006080431.jar
   org.eclipse.emf.query.doc_1.2.0.v20091210-1711.jar
   org.eclipse.emf.teneo.jpox.libraries_1.0.1.v200902271808.jar
   org.eclipse.emf.transaction.doc_1.4.0.v20091215-1213.jar
   org.eclipse.emf.validation.doc_1.3.0.v20091215-1218.jar
   org.eclipse.emf.workspace.doc_1.3.0.v200901271819.jar
   org.eclipse.emf.workspace.examples_1.2.0.v200903190036.jar
   org.eclipse.gef.doc.isv_3.5.0.v20100519-2050.jar
   org.eclipse.gmt.modisco.examples_0.8.0.v201006090939.jar
   org.eclipse.gmt.modisco.java.doc_0.8.0.v201006090939.jar
   org.eclipse.gmt.modisco.tool.metricsvisualizationbuilder_0.8.0.v201006090939.jar
   org.eclipse.gmt.modisco.xml.doc_0.8.0.v201006090939.jar
   org.eclipse.hyades.logging.core.sample_4.2.0.v201005061600.jar
   org.eclipse.hyades.probekit.doc.user_4.3.0.v201005212338.jar
   org.eclipse.hyades.test.doc.user_4.5.0.v201005272100.jar
   org.eclipse.jst.server.generic.jboss_1.6.1.v200904151730.jar
   org.eclipse.jst.server.generic.jonas_1.5.205.v200805140145.jar
   org.eclipse.jst.server.generic.oc4j_1.5.206.v20090812.jar
   org.eclipse.linuxtools.cdt.autotools_docs_2.0.1.201006091044.jar
   org.eclipse.linuxtools.cdt.libhover.glibc_1.0.1.201006091044.jar
   org.eclipse.linuxtools.cdt.libhover.library_docs_1.0.1.201006091044.jar
   org.eclipse.linuxtools.cdt.libhover.libstdcxx_1.0.0.201006091044.jar
   org.eclipse.linuxtools.changelog.doc_2.6.4.201006091044.jar
   org.eclipse.m2m.atl.doc_3.1.0.v201006080953.jar
   org.eclipse.m2m.atl_3.1.0.v201006080953.jar
   org.eclipse.mat.ui.help_1.0.0.201005201128.jar
   org.eclipse.mtj.branding_1.0.0.v201006021259.jar
   org.eclipse.mtj.doc.isv_1.0.1.v201006021259.jar
   org.eclipse.mtj.doc.user_1.0.1.v201006021259.jar
   org.eclipse.mylyn.help.ui_3.4.0.v20100608-0100-e3x.jar
   org.eclipse.net4j.sdk_3.0.0.v20100520-0834.jar
   org.eclipse.photran.managedbuilder.gnu.ui_6.0.0.201006111754.jar
   org.eclipse.ptp_4.0.0.201006111754.jar
   org.eclipse.riena.client.communication_2.0.0.v20100608_2_0_0_RC4.jar
   org.eclipse.riena.client.ridgets_2.0.0.v20100608_2_0_0_RC4.jar
   org.eclipse.riena.client_2.0.0.v20100608_2_0_0_RC4.jar
   org.eclipse.riena.server_2.0.0.v20100608_2_0_0_RC4.jar
   org.eclipse.rse_3.2.0.v201003151933.jar
   org.eclipse.sequoyah.localization.android.help_1.0.0.I20100526-1035.jar
   org.eclipse.swordfish.compatibility.cxf.minimal_0.10.0.v201006091040.jar
   org.eclipse.swordfish.compatibility.wsdl4j_0.10.0.v201006091040.jar
   org.eclipse.team.svn.core.nl1_0.7.9.I20100512-1900.jar
   org.eclipse.team.svn.help_0.7.9.I20100512-1900.jar
   org.eclipse.team.svn.nl1_0.7.9.I20100512-1900.jar
   org.eclipse.team.svn.ui.nl1_0.7.9.I20100512-1900.jar
   org.eclipse.team.svn_0.7.9.I20100512-1900.jar
   org.eclipse.tptp.examples_4.6.0.v201005061600.jar
   org.eclipse.tptp.monitoring.doc.user_4.3.0.v201005061600.jar
   org.eclipse.tptp.monitoring.examples_4.6.0.v201005061600.jar
   org.eclipse.tptp.monitoring.instrumentation.doc.user_4.4.0.v201005061600.jar
   org.eclipse.tptp.monitoring.instrumentation.ui_4.5.0.v201005061600.jar
   org.eclipse.tptp.monitoring.instrumentation_4.4.0.v201005061600.jar
   org.eclipse.tptp.monitoring.managedagent.doc.user_4.4.0.v201005061600.jar
   org.eclipse.tptp.monitoring.managedagent.jmx_4.5.0.v201005061600.jar
   org.eclipse.tptp.monitoring.managedagent.ui_4.5.0.v201005061600.jar
   org.eclipse.tptp.monitoring.managedagent_4.5.0.v201005061600.jar
   org.eclipse.tptp.monitoring.notifications_4.5.0.v201005061600.jar
   org.eclipse.tptp.monitoring_4.6.0.v201005061600.jar
   org.eclipse.tptp.platform.agentcontroller.doc.user_4.3.0.v201005181900.jar
   org.eclipse.tptp.platform.core_4.7.0.v201005061600.jar
   org.eclipse.tptp.platform.doc.user_4.3.0.v201006021049.jar
   org.eclipse.tptp.platform.instrumentation.annotation_4.6.0.v201001151900.jar
   org.eclipse.tptp.platform.instrumentation.ui_4.4.0.v201005061600.jar
   org.eclipse.tptp.platform.probekit_4.5.0.v201005061600.jar
   org.eclipse.tptp.platform.profile.server.doc.user_4.4.0.v201005061600.jar
   org.eclipse.tptp.platform.profile.server_4.5.0.v201005061600.jar
   org.eclipse.tptp.platform.report_4.4.0.v201005061600.jar
   org.eclipse.tptp.platform.samples_4.5.0.v201005061600.jar
   org.eclipse.tptp.platform.trace_4.5.0.v201005061600.jar
   org.eclipse.tptp.platform.welcome_4.6.0.v201005061600.jar
   org.eclipse.tptp.test.recorders.url.doc.user_4.7.0.v201005212338.jar
   org.eclipse.tptp.test.tools.junit.plugin.doc.user_4.7.0.v201005212338.jar
   org.eclipse.tptp.test.tools_4.4.0.v200906041936.jar
   org.eclipse.tptp.test_4.4.0.v200906041936.jar
   org.eclipse.tptp.trace.arm.doc.user_4.4.0.v201005061600.jar
   org.eclipse.tptp.trace.arm.ui_4.4.0.v201005061600.jar
   org.eclipse.tptp.trace.arm_4.4.0.v201005061600.jar
   org.eclipse.tptp.trace_4.4.0.v201005061600.jar
   org.eclipse.uml2.doc_3.1.0.v201005031530.jar
   org.eclipse.wst.dtdeditor.doc.user_1.0.600.v201005192212.jar
   org.eclipse.wst.sse.doc.user_1.1.100.v201005192212.jar
   org.eclipse.wst.xml.xpath2.processor.doc.user_1.0.0.v201005240426.jar
   org.eclipse.wst.xmleditor.doc.user_1.0.700.v201005192212.jar
   org.eclipse.wst.xsl.doc_1.0.100.v201004292007.jar
   org.eclipse.wst.xsl.saxon_1.0.100.v201004290328.jar
   org.eclipse.wtp.epp.package.jee.intro_1.3.0.v201005102030.jar
   org.eclipse.xpand.doc_1.0.0.v201006080443.jar
   org.eclipse.xtext.xtext.ui.examples_1.0.0.v201006080523.jar
Comment 1 David Williams CLA 2010-06-14 01:34:15 EDT
assigning to self to reduce some spam mail, but anyone with a bundle in these lists they want to fix, could open bugs in their own component.
Comment 2 Eike Stepper CLA 2010-06-14 01:48:24 EDT
(In reply to comment #0)
>         org.eclipse.emf.cdo.dawn.codegen.dawngenmodel.source

This is a source bundle generated by Buckminster. I don't see why it's supposed to be a *Java* bundle:

Manifest-Version: 1.0
Ant-Version: Apache Ant 1.7.1
Created-By: 1.5.0_22-b03 (Sun Microsystems Inc.)
Bundle-Name: CDO Dawn Codegen Genmodel Source
Eclipse-SourceBundle: org.eclipse.emf.cdo.dawn.codegen.dawngenmodel;ve
 rsion="0.2.0.v20100519-1648";roots="."
Bundle-Vendor: Eclipse Modeling Project
Bundle-ManifestVersion: 2
Bundle-SymbolicName: org.eclipse.emf.cdo.dawn.codegen.dawngenmodel.sou
 rce;singleton:=true
Bundle-Version: 0.2.0.v20100519-1648



>    org.eclipse.emf.cdo.dawn.sdk_0.2.0.v20100602-1722.jar
>    org.eclipse.emf.cdo.sdk_3.0.0.v20100520-0807.jar
>    org.eclipse.net4j.sdk_3.0.0.v20100520-0834.jar

Fixed.
Comment 3 David Williams CLA 2010-06-14 03:25:33 EDT
(In reply to comment #2)
> (In reply to comment #0)
> >         org.eclipse.emf.cdo.dawn.codegen.dawngenmodel.source
> 
> This is a source bundle generated by Buckminster. I don't see why it's supposed
> to be a *Java* bundle:
> 

I think my little heuristic just looks for .class files, or nested jar files ... so, could be a mistake in that heuristic. I'm not sure I look inside the nested jar files. Maybe that's the error in the heuristic? 

thanks,
Comment 4 Eike Stepper CLA 2010-06-14 04:18:45 EDT
(In reply to comment #3)

Okay, this hint was helpful. One of my committers accidentally added the bin/ folder to the build output. It's removed now.
Comment 5 David Williams CLA 2010-06-14 23:13:33 EDT
Created attachment 171892 [details]
updated data as of 6/14 11 pm eastern

one bundle corrected (I think by removing its accidental java code?)
Comment 6 Eike Stepper CLA 2010-06-15 02:14:07 EDT
(In reply to comment #5)
> one bundle corrected (I think by removing its accidental java code?)

No, fully consciously. Before the bin/ folder has been copied to the source bundle, IIRC.

Now tehre's still one bundle left for me: org.eclipse.emf.cdo.dawn.examples_0.2.0.v20100614-1655.jar

It's really "just" a branding plugin for an examples feature. Am I supposed to fix this thing for Helios or can I do it in maintenance?
Comment 7 David Williams CLA 2010-06-15 02:31:40 EDT
> 
> It's really "just" a branding plugin for an examples feature. Am I supposed to
> fix this thing for Helios or can I do it in maintenance?

Maintenance. If then. I'd suggest fixing it only when there was some other reason to touch the bundle.
Comment 8 William Piers CLA 2010-06-15 03:32:33 EDT
The M2M-ATL plugins have been fixed, rebuild and contributed to Helios, as it was already needed to fix bug 316720.
Comment 9 David Williams CLA 2010-06-15 09:41:59 EDT
Created attachment 171928 [details]
updated data as of 6/15 9 am eastern
Comment 10 David Williams CLA 2010-06-17 09:40:05 EDT
Created attachment 172119 [details]
updated data as of 6/17 9 am eastern
Comment 11 Matthias Sohn CLA 2010-06-18 18:42:59 EDT
Non Java Bundles with a BREE: 97
   org.eclipse.egit.doc_0.8.4.jar
   org.eclipse.egit_0.8.4.jar

This has been fixed for egit 0.9
Comment 12 Krum Tsvetkov CLA 2010-07-01 05:38:21 EDT
Non Java Bundles with BREE: 101
org.eclipse.mat.ui.help_1.0.0.201005201128.jar

This has been fixed. Too late for Helios. We'll include the fix for the Helios SP1
Comment 13 David Williams CLA 2011-06-18 00:40:07 EDT
See bug 347240 for Indigo report.