Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 316680

Summary: jgit-cli log command should support --maxcount
Product: [Technology] JGit Reporter: Denny Valliant <valliantster>
Component: JGitAssignee: Christian Halstrick <christian.halstrick>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: robin.rosenberg, stefan.lay, tomasz.zarna
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Bug Depends on:    
Bug Blocks: 357774    
Attachments:
Description Flags
patch file adding CommitCountRevFilter
none
simple test for CommitCountRevFilter
none
adds the --max-count argument none

Description Denny Valliant CLA 2010-06-12 07:54:28 EDT 
Build Identifier: 

jgit-cli log command should support --maxcount

Seems like the way to do this would be to create a RevFilter for counting commits.

Which is what I did.  CommitCountRevFilter has max(int) for limiting results.  Doubt anyone would want min(int) or some such, but that was the thinking.

Reproducible: Always
Comment 1 Denny Valliant CLA 2010-06-12 07:56:26 EDT 
Created attachment 171780 [details]
patch file adding CommitCountRevFilter
Comment 2 Denny Valliant CLA 2010-06-12 07:58:16 EDT 
Created attachment 171781 [details]
simple test for CommitCountRevFilter
Comment 3 Denny Valliant CLA 2010-06-12 08:01:18 EDT 
Created attachment 171782 [details]
adds the --max-count argument
Comment 4 Christian Halstrick CLA 2011-07-07 10:48:54 EDT 
You should propose this change to gerrit [1] as described in our contributors guide [2]. I can help you with that or do that for you. Please tell what you prefer.
Comment 5 Tomasz Zarna CLA 2011-12-15 05:49:20 EST 
Pushed a changeset as http://egit.eclipse.org/r/4827, didn't use Denny's patches.
Comment 6 Robin Rosenberg CLA 2011-12-23 13:28:49 EST 
248959146a383ecbcd6e55919a9595c3b3b7467d merged