Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 316665

Summary: [assist] create method from unresolved replace callin RHS adds "callin" modifier
Product: [Tools] Objectteams Reporter: Stephan Herrmann <stephan.herrmann>
Component: OTDTAssignee: Stephan Herrmann <stephan.herrmann>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 0.7   
Target Milestone: 0.7   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
test & fix none

Description Stephan Herrmann CLA 2010-06-11 19:57:32 EDT 
When the base method spec of a replace callin is unresolved,
the quickfix for creating this method in the base class wrongly
adds the callin modifier.
Comment 1 Stephan Herrmann CLA 2010-06-13 05:23:29 EDT 
Created attachment 171797 [details]
test & fix

This patch checks whether the unresolved method spec, on which' behalf
the quick fix is started, is the role-side. Only if so is a "callin"
modifier ever inserted.

Additionally, I made sure that no add-cast proposals are created
for generated variabls (starting with "_OT$"). The test had produced
a proposal to add a cast to "_OT$base".
Comment 2 Stephan Herrmann CLA 2010-06-13 05:30:34 EDT 
Patch was committed as r475 + r476.
Comment 3 Stephan Herrmann CLA 2010-07-02 12:52:39 EDT 
Verified using build 201007011455.