Bugzilla – Full Text Bug Listing
| Summary: | scheduled presentation fails to show due tasks for others scheduled for This Week | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Mik Kersten <mik.kersten> | ||||||
| Component: | Mylyn | Assignee: | Robert Elves <robert.elves> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | major | ||||||||
| Priority: | P1 | CC: | steffen.pingel | ||||||
| Version: | unspecified | ||||||||
| Target Milestone: | 3.4.1 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows 7 | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Mik Kersten
The scheduled presentation generally ignores task relationships. I can reproduce this with any task that is: * Not due for me * Scheduled for This Week It does not show in the scheduled presentation. To reproduce schedule any Eclipse.org bug not assigned to you for This Week and set a due date on it. *** Bug 316681 has been marked as a duplicate of this bug. *** Let's try to do a fix. There doesn't appear to be sufficient api to fix the issue. For repository tasks, we're unable to determine if the due date set is by virtue of a shared due date being set or a local due date being set (in the execution path, we're unable to test if the repo supports due date setting or not). Currently we just test and reveal if due date set and owned by user. But in the case were a repo doesn't support due dates, and a local due date is set, and the user is not owner, the task will not appear. That sounds right. We would probably to modify the API to address that. I am not sure I understand how that relates to this bug though. I thought that was tracked here: bug 316188: private due dates for repositories that do not support shared due dates are not treated as personal? It seemed to me that the bug described by Mik was caused by the duplicate filtering that should in this case not filter the bug from the This Week bin since the due date is not personal and hence the bug is not shown in day bins. Created attachment 172011 [details]
patch
yes, you're correct, the bug mentioned in the summary shoudl have a solution along these lines I believe.
Created attachment 172012 [details]
mylyn/context/zip
Bootsrapping on the patch now. I'm working with the patch, and did an A/B by opening up two Eclipses on the same Task List. The instance of the problem I was seeing before is gone, so as far as I can tell the bug is fixed. Steffen, can you confirm? Is this the last remaining major defect of the scheduled presentation? If so, it is critical that we get this out asap, whether that means 3.4.0 or 3.4.1. Rob: Haven't heard back from Steffen yet. Is this tested sufficiently on your end? Any reason you shouldn't commit it? I haven't noticed any problems working on the patch. I find that the code that populates the scheduled containers is not very readable which make it difficult to verify whether this is the right fix. Rob, could you add some basic test coverage? I understand that there are too many parameters to test for all combinations but it's critical that we have some coverage that ensures that scheduled or due tasks indeed show in the presentation. Have started on tests (still sitting in my workspace) We need to get this committed one way or another. This bug is preventing proper dogfooding of the presentation. I'm all for the tests, but not at the cost of having us discouraged from using it. Mik, I've committed that change and will commit more test coverage shortly. I don't understand this concern. Anyone running bootstrapped who wants to dogfood the presentation can simply apply the patch. Committed some test coverage I assume this got committed to head? Let me know if you want me to apply it to the 3.4.x branch and run a build. Yes, committed to head, if you could merge to 3.4.x that would be great. Patch committed to e_3_6_m_3_4_x branch. I'll kick off a new build. Thanks. |