Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 316648

Summary:

Run rpmlint menu contribution appears where it shouldn't

Product:

[Tools] Linux Tools

Reporter:

Andrew Overholt <overholt>

Component:

RPM

Assignee:

Alexander Kurtakov <akurtakov>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

linux.rpm-inbox

Version:

0.6

Target Milestone:

0.7

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
Test patch for 316648	akurtakov: iplog+

Description Andrew Overholt

2010-06-11 15:27:08 EDT

I just noticed that a plain text editor with a .stp file loaded has "Run rpmlint" in the context menu.  We should restrict this to the .spec editor and RPM projects.

Comment 1 Charley Wang

2010-06-14 11:30:20 EDT

Created attachment 171837 [details]
Test patch for 316648

Result: Only activate rpmlint action if the file was opened in the specfile editor. This means if a user manually chooses to open the .spec file with a different editor they will not see the rpmlint menu contribution in the editor's context menu. 

I'll keep looking for a way to grab the filename which would be better, the standard technique doesn't seem to be working.

Comment 2 Alexander Kurtakov

2010-10-26 06:43:11 EDT

Applied in r 25550.