Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 316643

Summary:

Cannot enter Report Conversion Patterns on API Use Report External Tool Launch

Product:

[Eclipse Project] PDE

Reporter:

Martin Oberhuber <mober.at+eclipse>

Component:

API Tools

Assignee:

Michael Rennie <Michael_Rennie>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

darin.eclipse, Olivier_Thomann

Version:

3.6

Flags:

Olivier_Thomann: review+

Target Milestone:

3.6.1

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
fix	none

Description Martin Oberhuber

2010-06-11 14:48:57 EDT

Build ID: I20100608-0911 (3.6rc4a)



1. Create an External Tool Launch for an API Use Report
2. Switch to the "Patterns" tab
3. Press "Add..."
4. Pick "Report Conversion Pattern", Next
5. Enter any Pattern, Finish

--> On the Launch Config dialog, the "Apply" button is not enabled
--> When switching to the "API Use Report" tab and back, the new pattern is gone
--> When choosing "Run", the new pattern is gone

It looks like the lack of a defined "Kind" for the report conversion pattern might be causing the problem that it cannot be saved.

I once got an NPE logged while playing with API Tooling, but it's likely not related to this issue:

java.lang.NullPointerException
at org.eclipse.pde.api.tools.ui.internal.use.PatternWizard.performFinish(PatternWizard.java:80)
at org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:811)
at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:430)
at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:624)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:234)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4066)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3657)
at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
at org.eclipse.jface.window.Window.open(Window.java:801)
at org.eclipse.pde.api.tools.ui.internal.use.ApiUsePatternTab.doEdit(ApiUsePatternTab.java:253)
at org.eclipse.pde.api.tools.ui.internal.use.ApiUsePatternTab$7.widgetSelected(ApiUsePatternTab.java:219)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:234)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4066)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3657)
at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
at org.eclipse.jface.window.Window.open(Window.java:801)
at org.eclipse.debug.internal.ui.launchConfigurations.LaunchConfigurationsDialog.open(LaunchConfigurationsDialog.java:1133)
at org.eclipse.debug.ui.DebugUITools$1.run(DebugUITools.java:398)
at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
at org.eclipse.debug.ui.DebugUITools.openLaunchConfigurationDialogOnGroup(DebugUITools.java:406)
at org.eclipse.debug.ui.DebugUITools.openLaunchConfigurationDialogOnGroup(DebugUITools.java:340)
at org.eclipse.debug.ui.actions.OpenLaunchDialogAction.run(OpenLaunchDialogAction.java:81)

Comment 1 Michael Rennie

2010-06-11 16:27:24 EDT

Created attachment 171769 [details]
fix

The problem was that we did not set the pattern kind when we initially create the control in the non-edit scenario for report-to patterns

Comment 2 Olivier Thomann

2010-06-15 12:20:39 EDT

Patch looks good.

Comment 3 Michael Rennie

2010-06-18 10:35:51 EDT

applied to HEAD and 3.6.1

Comment 4 Darin Wright

2010-08-20 16:39:29 EDT

+1