Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 316641

Summary:	bundles with compile errors never published even through p2.publishonerror is set to "true"
Product:	[Eclipse Project] PDE	Reporter:	Andrew Niefer <aniefer>
Component:	Build	Assignee:	pde-build-inbox <pde-build-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	Kirill.Balod
Version:	4.0
Target Milestone:	3.7 M1
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:	315762
Bug Blocks:

Description Andrew Niefer

2010-06-11 14:20:02 EDT

+++ This bug was initially created as a clone of Bug #315762 +++

Build Identifier: 3.6RC2

org.eclipse.pde.internal.build.builder.ModelBuildScriptGenerator has an mistake and as result generated build.xml contains condition:
        <property name="compilation.problem.marker" value="${build.result.folder}/compilation.problem"/>
        <condition property="compilation.problem.marker.exists" value="true"        >
            <and>
            <available file="${compilation.problem.marker}"/>
            <isfalse value="p2.publishonerror"/>
            </and>
        </condition>
where: 
<isfalse value="p2.publishonerror"/>
because "isfalse - Tests whether a string is not true, the negation of <istrue>" (c) Ant Manual - this condition always true independently of "p2.publishonerror" property
It should be:
<isfalse value="${p2.publishonerror}"/>

It is result of fix of bug [269972]
https://bugs.eclipse.org/bugs/show_bug.cgi?id=269972
	





Reproducible: Always

Comment 1 Andrew Niefer

2010-06-11 14:20:27 EDT

Fixed in HEAD for 3.7

Comment 2 Andrew Niefer

2010-06-11 14:21:16 EDT