Bugzilla – Full Text Bug Listing
| Summary: | Wrong name for JSF plugins in helios update site | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [WebTools] Java Server Faces | Reporter: | Robin Rosenberg <robin.rosenberg> | ||||||||
| Component: | JSF Tools | Assignee: | Raghunathan Srinivasan <raghunathan.srinivasan> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | david_williams, raghunathan.srinivasan | ||||||||
| Version: | 3.2 | Flags: | david_williams:
pmc_approved+
raghunathan.srinivasan: pmc_approved? (naci.dai) deboer: pmc_approved+ raghunathan.srinivasan: pmc_approved? (neil.hauge) raghunathan.srinivasan: pmc_approved? (kaloyan) |
||||||||
| Target Milestone: | 3.2.1 | ||||||||||
| Hardware: | Other | ||||||||||
| OS: | All | ||||||||||
| See Also: |
https://git.eclipse.org/r/114239 https://git.eclipse.org/c/jsf/webtools.jsf.git/commit/?id=51cd0b65c9a35d6b19918b0f45a59a38c5bcc1d8 |
||||||||||
| Whiteboard: | PMC_approved | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Robin Rosenberg
This is bad ... but ... it is only for 'test' feature (right?) I notice another problem is that both JSF (non-sdk) feature, and the JSF SDK feature are in the non-sdk category ... and JSF SDK does not show up in the SDK category. The seconds one "name" is not a test feature, I think. (In reply to comment #2) > The seconds one "name" is not a test feature, I think. Ah, I see it now. It was not in a category, but if I removed categories, I could find it. It belongs to jsf source feature. org.eclipse.jsf.feature.source.feature.group Must be something amiss in the "sourceFeatureTemplate" folder. For the test one, '%feature.name' in the feature.xml file should be '%name'. Raghu, I suggest you target this for maintenance. Since doesn't effect the common repo, and the "test" one is not visible in products, this does not seem worth a respin. I have opened bug 316651 to handle the category problem (that's in a category.xml file, in releng.wtpbuilder). Thank you for reporting. Created attachment 171772 [details]
Fix for org.eclipse.jsf.feature.source.feature.group name
Created attachment 171773 [details]
Fix for Test feature name
Agreed on the test feature. I am assuming the SDK feature name is not going to be an issue for an adopter. The provider name should be "Eclipse Web Tools Platform". Just as well fix it too, since toughing the file. Created attachment 171775 [details]
Fix for org.eclipse.jsf.feature.source.feature.group
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such.
Incorrect name of the JSF feature in the update manager.
* Is there a work-around? If so, why do you believe the work-around is insufficient?
no
* How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added?
manual
* Give a brief technical overview. Who has reviewed this fix?
see comment 3
* What is the risk associated with this fix?
none-low
remember to put "PMC" in whiteboard, to get it to show up on summary page. Change released to 3.2.1 New Gerrit change created: https://git.eclipse.org/r/114239 Gerrit change https://git.eclipse.org/r/114239 was merged to [master]. Commit: http://git.eclipse.org/c/jsf/webtools.jsf.git/commit/?id=51cd0b65c9a35d6b19918b0f45a59a38c5bcc1d8 |