| Summary: | makefile outline doesn't work with alternate encoding | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | Mike Kucera <mikekucera> | ||||
| Component: | cdt-editor | Assignee: | Anton Leherbauer <aleherb+eclipse> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Anton Leherbauer <aleherb+eclipse> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | ||||||
| Version: | 6.0.2 | ||||||
| Target Milestone: | 8.0 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
The encoding is not considered when the IMakefile model is initially created in org.eclipse.cdt.make.core.MakeCorePlugin.createMakefile(IFile) As soon as I start editing, the outline gets fixed because the reconciler uses the editor buffer to update the model. MakeCorePlugin.createMakefile(IFile) does now respect the IFile encoding. *** cdt cvs genie on behalf of aleherbau *** Bug 316502 - makefile outline doesn't work with alternate encoding [*] MakeCorePlugin.java 1.45 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.make.core/src/org/eclipse/cdt/make/core/MakeCorePlugin.java?root=Tools_Project&r1=1.44&r2=1.45 [*] MakefileReconcilingStrategy.java 1.12 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.make.ui/src/org/eclipse/cdt/make/internal/ui/text/makefile/MakefileReconcilingStrategy.java?root=Tools_Project&r1=1.11&r2=1.12 |
Created attachment 171657 [details] screeshot If I open a makefile that has EBCDIC encoding in the editor, then the outline view is all screwed up (probably also happens with other encodings too). Steps to reproduce: * create a makefile * set its encoding to Cp1047 * open the file in the editor