Bugzilla – Full Text Bug Listing
| Summary: | [LTTng] Histogram View short requests not coalesced with Control Flow View and Resources View | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Alvaro Sanchez-Leon <alvaro.sanchez-leon> | ||||||||
| Component: | LinuxTools | Assignee: | Bernd Hufmann <bernd.hufmann> | ||||||||
| Status: | CLOSED FIXED | QA Contact: | Francois Chouinard <fchouinard> | ||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | ||||||||||
| Version: | unspecified | ||||||||||
| Target Milestone: | --- | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 290046, 301629, 301630, 321364, 325661 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Alvaro Sanchez-Leon
Created attachment 181773 [details]
Improved Request Coalescing and other performance / usability improvements
In order to coalesce all requests of the short Histogram View, the Resource View and the Control Flow View, the interface of the TmfDataProvider had to be extended to allow other Data Providers, such as LttngSyntheticEventProvider, to notify about upcoming data requests. Once notified, the TmfDataProvider coalesces its requests with the requests from the LttngSyntheticEventProvider. Only when notified, that all pending requests are submitted the TmfDataProvider dispatches and executes the requests. This solution, allows to coalesce all foreground requests from the Control Flow View, Resource View and the short Histogram window. Additionally, it also a allows to coalesce long (background) requests from the Statistics View, long Histogram Window, indexing of the Experiment and indexing of the Kernel State System. The coalescing of background requests, minimizes the number of parsing of the experiment to only once at startup (if all views are open). The submitted patch improves the coalescing of requests and solves the issue reported in this bug. Additionally, this patch addresses some other issues that needed to be fixed for this bug fix and to improve overall usability and performance. Here is the list of areas addressed in the patch (including coalescing): - TMF/LTTng:coalescing of requests from multiple data providers - TMF/LTTng: improved cancelling of requests - LTTng: Remove dependency of requests of Statistic View, Control Flow View and Resource view. Now each view has its own LttngSyntheticEventProvider. This makes the whole GUI more responsive - TMF: Improved current event selection in TmfEventTable - Lttng: Optimize frequency of redraw of views to improve overall performance and usability. Created attachment 181862 [details]
Improved Request Coalescing and other performance / usability improvements (helios)
Updated patch which fixes an thread deadlock caused by canceling of requests
Created attachment 181863 [details]
Improved Request Coalescing and other performance / usability improvements (indigo)
Patch for Indigo branch
Comment on attachment 181863 [details]
Improved Request Coalescing and other performance / usability improvements (indigo)
Patch committed. Thanks Bernd.
Bug fixed and patch committed to Indigo. Comment on attachment 181862 [details]
Improved Request Coalescing and other performance / usability improvements (helios)
Should this patch be marked iplog+ as well? Or perhaps it should be marked obsolete?
Thanks for your help in matters related to IP :)
Andrew: the patch was also applied to the Helios branch but I forgot to mark it. Sorry. |