Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 316390

Summary: JAXB CLASS GEN WIZARD: Need consistency to access wizard
Product: [WebTools] Dali JPA Tools Reporter: Andrew Fernandez <ripsi_1>
Component: JAXBAssignee: Tran Le <tranle1>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: neil.hauge, shaun.smith
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Andrew Fernandez CLA 2010-06-09 17:38:58 EDT
Build Identifier: 

Currently the JAXB wizard is invoked on an XSD by right-clicking and choosing Generate > JAXB Classes...

Also, when I go to File > New > Other, I can go to JAXB and choose Chema from JAXB Classes (there's already a bug on the lack of a choice to choose a XSD to create classes from this pathway)

We should have consistency to access the JAXB wizard to create classes (or to create a schema file)

Shouldn't the JAXB wizard be under JAXB > Generate ... , instead of Generate > JAXB Classes so it can be found easier?

Reproducible: Always

Steps to Reproduce:
1. Create OEPE web service project in Helios
2. Place/create XSD in package under src
3. Right-click on XSD and go to Generate > JAXB Classes...
Comment 1 Andrew Fernandez CLA 2010-06-09 17:42:23 EDT
correction *****

Also, when I go to File > New > Other, I can go to JAXB and choose Schema from
JAXB Classes (there's already a bug on the lack of a choice to choose a XSD to
create classes from this pathway)

*******

Also, just to reiterate, the purpose here is to provide the same top level tree node to access Dali JAXB wizards.

In File > New > Other it's under JAXB

Yet for right click context menu it's Generate.

Shouldn't it be consistent, just like for the New dialog, and be under JAXB instead of Generate for the right-click context menu?
Comment 2 Neil Hauge CLA 2010-06-18 16:30:01 EDT
We do need some consistency here.  All wizards should be available from the New menu, so this should be addressed.  I think that it is also sometimes helpful to take advantage of existing context menus, in this case the Generate menu provides a nice launching point for this JAXB classes wizard.
Comment 3 Neil Hauge CLA 2010-07-19 13:20:56 EDT
Actually, I didn't realize that the other bug 315813 already well covers what I think needs to be done in this area.  There is a higher level requirement that context menu creation should only be done when absolutely necessary in the core.  Since an established "Generate" menu already exists in WTP, we are better off reusing this as opposed to creating an additional context menu item in this case.

Marking as WONTFIX for now, but please re-open if anyone feels strongly otherwise.
Comment 4 Andrew Fernandez CLA 2010-07-19 13:48:31 EDT
This bug and 315813 are from 2 different pathways.

One from right-click and the other from File > New > etc...

Therefore 2 different bugs.

I still believe Generate is too general. 

We need to think about how Generate is too general from some selections like right-click when people are trying to find certain wizards.

Therefore the bug.

We have a UI design engineer working in our team who's provided some good guidance on this. Not sure if you guys have something like that on your team. Sometimes it's beneficial for cases like this.

Just my 2 cents...
Comment 5 Andrew Fernandez CLA 2010-07-19 13:51:35 EDT
Just one additional thought...

We are providing open source stuff but we also work for Oracle too.

We need to provide a way when people access these wizards to say it's Oracle provided although it's open source too.

Therefore allowing for Oracle JAXB to be somewhere in the access path for these wizards...
Comment 6 Neil Hauge CLA 2010-07-19 17:42:50 EDT
(In reply to comment #4)
> This bug and 315813 are from 2 different pathways.

> 
> One from right-click and the other from File > New > etc...
> 
> Therefore 2 different bugs.

Yes, I agree.  That is why this bug was marked WONTFIX as opposed to DUPLICATE.
> 
> I still believe Generate is too general. 

That is a valid viewpoint.

> 
> We need to think about how Generate is too general from some selections like
> right-click when people are trying to find certain wizards.
> 
> Therefore the bug.

The "New" wizard entry will be located in a JAXB node, so that path should be covered.  I think this is an area where a core Eclipse component requirement may differ from an adopter's requirement.  An adopting product can actually remove the wizard entry from the core JPT UI via Capabilities and place the wizard in a different, preferred location.  One of the reasons that a JAXB sub-menu was not added was that there would only be one action in that sub-menu, "Generation JAXB Classes".  If you simply put "Generate JAXB Classes" on the context menu, it would look odd to have a "Generate" sub-menu and then "Generate JAXB Classes" as the next menu item.  Many of our adopters would not be happy about this, as context menu size reduction is a very strong requirement for them.

> 
> We have a UI design engineer working in our team who's provided some good
> guidance on this. Not sure if you guys have something like that on your team.
> Sometimes it's beneficial for cases like this.

I'd be happy to hear and consider their feedback on this.


(In reply to comment #5)

> 
> Therefore allowing for Oracle JAXB to be somewhere in the access path for these
> wizards...

I'm not sure if you are talking about Oracle based JAXB implementations or Oracle based wizards.

JAXB class generation is largely a standards based operation.  It is likely more confusing than helpful to the user to distinguish between Oracle specific generation and generic JAXB generation.  This distinction will be made in the selection of JAXB Platform (or implementation) when setting up the project, or when generating JAXB classes for the first time.

This suggestion sounds like more of a requirement for an Oracle adopting product, but I may be confused.


It seems I may have prematurely marked this as WONTFIX since there appears to be some additional debate on this issue.  Leaving untargeted.