Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 316334

Summary: Breaking change on org.eclipse.jetty.client.HttpExchange
Product: [RT] Jetty Reporter: Pascal Rapicault <pascal>
Component: clientAssignee: Greg Wilkins <gregw>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P3 CC: hmalphettes, jetty-inbox, mgorovoy, tjwatson
Version: 7.1.3   
Target Milestone: 7.1.0   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:

Description Pascal Rapicault CLA 2010-06-09 12:38:11 EDT
The method isDone(int) that once existed in org.eclipse.jetty.client.HttpExchange from bundle org.eclipse.jetty.client 7.0.0.20091005 has now been changed to isDone() in version 7.1.3.v20100526

This represents a breaking change in the API signature of the class.
Comment 1 Hugues Malphettes CLA 2010-06-09 12:50:47 EDT
As discussed on #equinox-dev: we are trying to get this into the eclipse build for Helios.
Comment 2 Michael Gorovoy CLA 2010-06-09 13:33:26 EDT
Change in question comes from r968 that fixed Bug 290761 - HttpExchange isDone
handles intercepted events.
Comment 3 Michael Gorovoy CLA 2010-06-09 13:49:01 EDT
Committed r1954.
Comment 4 Michael Gorovoy CLA 2010-06-09 19:32:57 EDT
The method isDone(int status) has been added back to the org.eclipse.jetty.client.HttpExchange and deprecated. Internally, it ignores the value of a parameter, and calls isDone() to properly determine if the exchange has been completed.
Comment 5 Hugues Malphettes CLA 2010-06-09 20:18:46 EDT
It is fixed with 7.1.4.v20100609 and it is in the Helios release.
Comment 6 Pascal Rapicault CLA 2010-06-09 21:48:38 EDT
Thank you for the quick turnaround!