Bugzilla – Full Text Bug Listing
| Summary: | [Compatibility] turn actionSets into MenuContributions | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] e4 | Reporter: | Paul Webster <pwebster> | ||||||||||||||
| Component: | UI | Assignee: | Paul Webster <pwebster> | ||||||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||||||
| Severity: | normal | ||||||||||||||||
| Priority: | P3 | CC: | bokowski, emoffatt, remy.suen | ||||||||||||||
| Version: | 1.0 | ||||||||||||||||
| Target Milestone: | 1.0 RC1 | ||||||||||||||||
| Hardware: | PC | ||||||||||||||||
| OS: | Linux | ||||||||||||||||
| See Also: | https://bugs.eclipse.org/bugs/show_bug.cgi?id=549234 | ||||||||||||||||
| Whiteboard: | |||||||||||||||||
| Bug Depends on: | |||||||||||||||||
| Bug Blocks: | 316304 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Paul Webster
Created attachment 171886 [details]
ActionSets v01 (draft)
I can see the actionSet EP now, and generate my internal objects ... translating them into MenuContributions will be more ... uh, difficult.
PW
Created attachment 172005 [details]
ActionSets v02 (draft)
work in progress.
This turns the menuContributions with popup: or menu: and the actionSets into MMenuContributions.
Then it applies a merging algorithm to them to condense them down from a large number.
PW
(In reply to comment #2) > Created an attachment (id=172005) [details] > ActionSets v02 (draft) Committed. PW Created attachment 172179 [details]
actionSet visibleWhen v02 (draft)
This applies the visibleWhen logic to actionSets. The perspective needs to activate contexts equivalent to the actionSet IDs. Then the menu items should appear while in that perspective.
They're not quite there yet.
PW
actionSet contributions to a window's menu bar should now be visible on the first startup with no deltas.xml. Action sets aren't fully supported until perspectives can specify which actionSets they support. 3 options come to mind: 1) tag it: require tags like "actionSet:the.id" and scan them, parse them, activate them. 2) model it: Add something to MPerspective to hold the IDs 3) activate binding contexts, which also manage actionSet visibility. PW Created attachment 172665 [details]
actionSet visibleWhen v03
Created attachment 172806 [details]
actionSet visibleWhen v04 (draft)
The is working on the main menu bar (and toolbar contributions). Work in progress.
PW
Created attachment 172855 [details]
actionSet visibleWhen v05
The main menu bar is now filled on startup. all of its contributions have RATs that try and update their visibility. The initial visibility seems good. But switching to the CVS Repo perspective doesn't make Run disappear or CVS menu suddenly show up yet.
Released.
PW
toolbar contributions now work the same way as menu contributions. trim contributions will need a little more thought. I believe they simply need to be broken up ... i.e. TrimContribution contributes empty MToolBars, and the toolbar contents come from MToolBarContributions. The trim renderer will fill in trim children (i.e. toolbars) and the toolbar renderer will fill in toolbar children (tool items, for the most part). PW Each area is now simpler: Trim contributions to contribute to the trim, toolbar contributions to contribute to toolbars in the trim or parts. I have 2 presentation toolbars that need to resolve to one. I also don't have a CVS menu when I switch to the CVS Repo perspective. PW . |