Bugzilla – Full Text Bug Listing
| Summary: | [hotbug] Backport 292943 to wtp 3.0.5Patch | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [WebTools] Java Server Faces | Reporter: | Xiaonan Jiang <xiaonan_jiang> | ||||||||
| Component: | JSF Tools | Assignee: | Raghunathan Srinivasan <raghunathan.srinivasan> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | david_williams, gerry.kessler, raghunathan.srinivasan, robert_gallagher, yurykats | ||||||||
| Version: | unspecified | Flags: | gerry.kessler:
review+
|
||||||||
| Target Milestone: | 3.0.5 P | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows XP | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Xiaonan Jiang
Created attachment 171525 [details]
Backport Patch
Can you please comment on whether the patch can be applied? Tip: if you just put the word "bug" followed by the bug number, the bugzilla software will create an HTML link directly to it, which I'll do now to illustrate, and provide a link for everyone, and so I won't have to type it in the URL field myself :) Such as bug 292943. Can you please comment on whether the patch can be applied? Our adopter product is rapidly approaching its release date and we really need this patched. Thanks! Created attachment 173158 [details]
Updated backport patch
This updated patch is very nearly the same as the original patch, except that it fixes an issue that was introduced by the original fix. I have run the junit tests and done some basic testing, but it could probably use some more.
Thanks for reviewing the patch, Gerry. What's the next step, can the patch be applied now? Here's what I think next steps are. From what I see, the patch changes 3 modules: org.eclipse.jst.jsf.standard.tagsupport org.eclipse.jst.jsf.common org.eclipse.jst.jsf.metadata.tests Two of these already have R3_0_5_patches branches. (so, those branches should be loaded up in your workspace). org.eclipse.jst.jsf.standard.tagsupport has not been branched for 305 patches, so it should be. From what I can see in 305 Release map files, the version of this project that was released with WTP 3.0.5 was v20090128, so that version should be loaded in your workspace, and then created a branch from it, named R3_0_5_patches Apply patch, commit changes, and tag with an ordinary tag, such as v201007011300, and report the tags you choose here. (i.e. you don't really need to do the "release" step, unless you just want to). Report the tags here, and I can do the rest. Which is update org.eclipse.jst.web_core.feature.patch and I can update the map files with the tags reported. But ... I did try applying the patch in my local workspace. The two code ones applied cleanly, but the one for the test bundle did not apply cleanly. Some missing class, or something. And, to be honest, we don't normally fix/build/run unit tests for patch builds, at least on this old stream. So, you can leave it out, as far as I'm concerned, and just tell us what test is likely to fail ... or, you are quite welcome to fix the patch so at least the code in the repo can be corrected ... even if we don't rebuild/run in the actual build. Much thanks, All modified plugins tagged as , v201007011626 Created attachment 173265 [details]
increment service field +1
Thanks Raghu, but now preparing the features, etc., I realize that ideally the service fields should be incremented by +1. Would you mind incrementing (and/or applying patch) and re-tagging/releasing?
Thank you
Done. Tag: v201007012100 |