| Summary: | [LTTng] Inconsistent results in CFV, RV and SV | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Francois Chouinard <fchouinard> | ||||||
| Component: | LinuxTools | Assignee: | Francois Chouinard <fchouinard> | ||||||
| Status: | CLOSED FIXED | QA Contact: | Francois Chouinard <fchouinard> | ||||||
| Severity: | critical | ||||||||
| Priority: | P3 | ||||||||
| Version: | unspecified | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Francois Chouinard
Created attachment 172080 [details]
Consistency patch
Some instability in the application was introduced when we started processing event requests concurrently. With this patch, the consistency is restored.
This patch addresses the problem by:
- Funneling all data accesses through the Experiment instead of accessing directly the underlying trace
- Removed the concept of main vs. clone to process FG/BG requests (a bad idea to start with) in favor of a PriorityBlockingQueue processed by a SingleThreadExecutor
- Modified the data queue shared by Producer/Consumer from a LinkedBlockingQueue to a SynchronousQueue (to accommodate LTTng's "special needs")
- Added some synchronization where concurrent accesses could corrupt things
A number of miscellaneous tweaks are also included:
- Added toString() and equals() where needed
- Set the HistogramView window to 1sec (in line with CFV and RV)
Note that some JUnits are now failing. They will need to be further analyzed to ensure no new problem was introduced.
This patch can't be committed before the JUnits pass.
Created attachment 172358 [details] Updated consistency patch - Misc fixes so the JUnits pass cleanly - Fixed the read/write timeout (temporary solution, see Bug216280) Comment on attachment 172358 [details]
Updated consistency patch
Patch committed
Patch committed Patch also committed to to the Helios maintenance branch. Delivered with 0.6.1 *** Bug 313966 has been marked as a duplicate of this bug. *** |