Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 316246

Summary: Clean up code should not only run on IPresentationEngine.stop()
Product: [Eclipse Project] e4 Reporter: Thomas Schindl <tom.schindl>
Component: UIAssignee: Project Inbox <e4.ui-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: emoffatt, pwebster, remy.suen
Version: 0.9   
Target Milestone: 1.0 RC0   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Attachments:
Description Flags
Fix position to run cleanup code
none
patch
none
patch none

Description Thomas Schindl CLA 2010-06-09 03:09:39 EDT 
This results in the fact the clean up code in there is not run.
Comment 1 Thomas Schindl CLA 2010-06-10 12:34:02 EDT 
Created attachment 171653 [details]
Fix position to run cleanup code

I think the clean up code is run in the wrong place and should run after the event loop is finished.
Comment 2 Thomas Schindl CLA 2010-06-10 12:49:51 EDT 
Created attachment 171654 [details]
patch
Comment 3 Thomas Schindl CLA 2010-06-10 12:54:35 EDT 
Paul, with the 1st patch I get a test failure but I'm uncertain whether this is a problem with the test.

2nd patch which disposes before closing the window fixes the problem as well. I guess we can go with the 2nd patch because the cleanUp() when called more than once is simply a no-op
Comment 4 Thomas Schindl CLA 2010-06-11 08:00:44 EDT 
Created attachment 171711 [details]
patch
Comment 5 Thomas Schindl CLA 2010-06-11 10:04:26 EDT 
released cleanup change to HEAD