Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 316233

Summary:	reformat source code
Product:	z_Archived	Reporter:	Steffen Pingel <steffen.pingel>
Component:	Mylyn	Assignee:	Steffen Pingel <steffen.pingel>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P4	CC:	steffen.pingel
Version:	unspecified
Target Milestone:	3.5
Hardware:	PC
OS:	Linux
Whiteboard:

Description Steffen Pingel

2010-06-08 23:04:12 EDT

The behavior of the Eclipse 3.6 code formatter differs slightly from previous versions which can cause Mylyn source code to get reformatted on save under certain conditions. This causes unrelated changes to end up in patches and commits which slows down reviews and makes tracking of changes more difficult.

In the past we have reformatted the entire source base in one go with updated formatting rules. It is usually better to do this before a release because reformatting can affect line numbers and make it more difficult to match stack traces. Unfortunately we are timed out for 3.4 and my attempts to set the new rules to match the old behavior were not successful.

I suggest the following: We go ahead with this once 3.4 has been branched and major outstanding patches have been applied. We will also need to agree on the new formatting settings and can use this as an opportunity to review the existing settings.

Comment 1 Steffen Pingel

2011-03-02 19:43:49 EST

I have applied the code formatting rules and also updated the code template for new files to use ${year} instead of 2010.