Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 316219

Summary:	[otmodel] OTModelManager cleanup may be incomplete
Product:	[Tools] Objectteams	Reporter:	Stephan Herrmann <stephan.herrmann>
Component:	OTDT	Assignee:	Stephan Herrmann <stephan.herrmann>
Status:	ASSIGNED ---	QA Contact:
Severity:	normal
Priority:	P3
Version:	1.4
Target Milestone:	---
Hardware:	PC
OS:	Linux
Whiteboard:	trac

Description Stephan Herrmann

2010-06-08 18:57:29 EDT

(originally from http://trac.objectteams.org/ot/ticket/115)

A CCE in JavaModelManager.closeChildren observed during migration to 3.4 revealed that cleanup for OTJavaElements might be incomplete, which could mean that the OTModelManager keeps elements that should actually be released. 

(comment:1)
Immediate patch for the CCE is in r18347

(comment:5)
See recent fixes regarding #233 plus r21628. Java elements are now properly cleaned up, yet propagation to cleaning up the OTModelManager is still missing.

When writing tests, r21643 might be a good starting point.

---

today's analysis: looking at http://trac.objectteams.org/ot/changeset/21628
it could well be that all we need is a test to verify that solution.
http://trac.objectteams.org/ot/changeset/21643 was mentioned as a potential
skeleton for a test. Perhaps a helper function OTModelManager.size()
could come handy for the test?

Comment 1 Stephan Herrmann

2010-06-29 09:35:27 EDT

Given the recent improvements in bug 317358 this shouldn't be too hard
any more. E.g., the patch from r18347 (objectteams.org) was discarded
as part of r543 (eclipse.org). Also patch r21628 was incorporated
into OTType (as of r543).


Good tests are actually the point here.