Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 316190

Summary:

NPE from remote java script launch delegate

Product:

[WebTools] JSDT

Reporter:

Curtis Windatt <curtis.windatt.public>

Component:

Debug

Assignee:

Michael Rennie <Michael_Rennie>

Status:

RESOLVED FIXED

QA Contact:

Simon Kaegi <simon_kaegi>

Severity:

normal

Priority:

CC:

thatnitind

Version:

3.2

Target Milestone:

---

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
fix	none

Description Curtis Windatt

2010-06-08 14:53:59 EDT

Not sure why my vm has no name, but the method is spec'd that is can return null.

eclipse.buildId=I20100530-0800
java.version=1.6.0_18
java.vendor=Sun Microsystems Inc.
BootLoader constants: OS=linux, ARCH=x86, WS=gtk, NL=en_CA
Framework arguments:  -product org.eclipse.sdk.ide -showlocation
Command-line arguments:  -product org.eclipse.sdk.ide -data /home/cwindatt/WS/Workspace Target -dev file:/home/cwindatt/WS/Workspace/.metadata/.plugins/org.eclipse.pde.core/Target/dev.properties -os linux -ws gtk -arch x86 -consoleLog -console -showlocation


Error
Tue Jun 08 13:52:16 CDT 2010
An internal error occurred during: "Launching New_configuration (16)".

java.lang.NullPointerException
	at org.eclipse.wst.jsdt.debug.internal.core.launching.RemoteJavaScriptLaunchDelegate.launch(RemoteJavaScriptLaunchDelegate.java:76)
	at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:853)
	at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:702)
	at org.eclipse.debug.internal.ui.DebugUIPlugin.buildAndLaunch(DebugUIPlugin.java:923)
	at org.eclipse.debug.internal.ui.DebugUIPlugin$8.run(DebugUIPlugin.java:1126)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)

Comment 1 Curtis Windatt

2010-06-08 16:51:59 EDT

I wasn't paying attention, the name isn't null, the vm is.  There should probably be a null check with a more descriptive error sent.  If the connector fails to establish a connection to the crossfire extension it may return null instead of throwing an IOException.  That could be a bug in the connector.

To make it a little better experience for me I added the following to RemoteJavaScriptLaunchDelegate just before the JavaScriptDebugTarget is created.

	if (vm == null){
			Status status = new Status(IStatus.ERROR, JavaScriptDebugPlugin.PLUGIN_ID, "Connection with the vm could not be established"); //$NON-NLS-1$
			throw new CoreException(status);
		}

Comment 2 Michael Rennie

2010-06-09 11:05:54 EDT

Created attachment 171537 [details]
fix

The underlying problem was that I did not respect my own API doc :)
In the Crossfire connector I was catching an IOException and returning null, when I should have been re-throwing the exception

Comment 3 Curtis Windatt

2010-06-09 11:12:41 EDT

I updated the patch on bug 312844 to include a fix to avoid the two cases where the connector could return null.

Comment 4 Michael Rennie

2010-06-09 11:46:12 EDT

applied patch to HEAD (to the crossfire dev bundle) - also throws an IOException for trying to auto-launch browser not on localhost.