Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 316164

Summary: [view management] view activation should be triggered by stack frames in default model
Product: [Eclipse Project] Platform Reporter: Darin Wright <darin.eclipse>
Component: DebugAssignee: Pawel Piech <pawel.1.piech>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ndsilva, pawel.1.piech
Version: 3.6Flags: darin.eclipse: review+
Target Milestone: 3.6.1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Fix. none

Description Darin Wright CLA 2010-06-08 12:11:39 EDT 
Follow up from bug 298648.

The fix to bug 298648 changed view activation to be triggered by any IDebugElement rather than just IStackFrames. In multi-language debug scenarios, this can cause thread/target selection to trigger undesired view activations. For example, if a thread has frames from different languages/models, but the thread is considered to be from one model, when resuming from a frame, the thread is selected causing other views to move to the foreground.

If a model wants elements other than stack frames to control view activation, IDebugModelProvider can be used/implemented.
Comment 1 Darin Wright CLA 2010-06-08 12:12:39 EDT 
Marking as 3.6.1 candidate, pending comments from Pawel.
Comment 2 Pawel Piech CLA 2010-06-08 13:32:46 EDT 
I did not know about this use case.  I'll undo the change and re-test.  However, it seems to me that using the stack frame as a test of whether to activate a view is a rather nuanced API feature of the view activation.  Seems that we should add something more explicit in the future.
Comment 3 Natasha D'Silva CLA 2010-07-06 12:29:25 EDT 
Pawel,
Have you been able to test? Did you find any problems?
Comment 4 Pawel Piech CLA 2010-07-06 23:11:47 EDT 
(In reply to comment #3)
> Pawel,
> Have you been able to test? Did you find any problems?

I'm sorry I haven't yet.  I'll make sure to get to it before the end of the week.
Comment 5 Pawel Piech CLA 2010-07-09 17:16:26 EDT 
Created attachment 173923 [details]
Fix.
Comment 6 Pawel Piech CLA 2010-07-09 17:17:33 EDT 
I reverted the logic back to use IStackFrame instead of IDebugElement.  Darin please review.
Comment 7 Darin Wright CLA 2010-07-12 14:26:58 EDT 
Verified.