Bugzilla – Full Text Bug Listing
| Summary: | Extra ending comment tag in helloworld-feature.xml | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Kit Lo <kitlo> | ||||||||
| Component: | UI | Assignee: | Darin Wright <darin.eclipse> | ||||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||||
| Severity: | major | ||||||||||
| Priority: | P3 | CC: | ankur_sharma, curtis.windatt.public, daniel_megert, darin.eclipse, d_l_hall, john.arthorne, kim.moir, pwebster, tieTYT | ||||||||
| Version: | 3.6 | Flags: | daniel_megert:
pmc_approved+
darin.eclipse: review+ |
||||||||
| Target Milestone: | 3.6.1 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows XP | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Kit Lo
Created attachment 171395 [details]
patch
This problem was introduced updating copyrights. We should probably fix this for 3.6. Due to this, the "Create a feature" step of the "Creating an Eclipse plug-in" cheat sheet is broken. The user ends up with an error message in the cheat sheet: "Error loading cheat sheet content. Cheat sheet content file ".../helloworld-feature.xml" could not be parsed, error at line 12, column 2". I guess the question is whether to fix for 3.6 or 3.6.1. Created attachment 171419 [details]
screen shot of broken cheat sheet
Created attachment 171421 [details]
updated copyright
Updated patch to reflect 2010 copyright year.
John, do you think we should fix this one for 3.6? It's not a critical stop-ship bug, but it is a definite glitch in the UI. John, when I talked to Darin my take was: fix if there's a rebuild but don't trigger a rebuild just because of that fix. It's not a must fix for me i.e. I can live with a fix in 3.6.1. (In reply to comment #8) > John, when I talked to Darin my take was: fix if there's a rebuild but don't > trigger a rebuild just because of that fix. It's not a must fix for me i.e. I > can live with a fix in 3.6.1. Yes, makes sense to me. I'm wondering why our CHKPII test didn't catch this - is CHKPII configured to ignore these files? If so can we get them included so we can avoid problems like this in the future? I'm not sure if CHKPII will check the well-form-ness of the XML files. But, we can always request for an enhancement. Kim, if there's going to be another build towards 3.6, please let us know, as we will contribute to fix this bug. Adding PMC approval flag. Note: we won't release to HEAD until we get notification of the build. That way HEAD stays in synch with the build contents. >CHKPII configured to ignore these files?
I don't think so (at least it's not the case on my machine).
This is a 3.6.1 candidate Applied and released to 3.6.1. Applied to HEAD. *** Bug 321420 has been marked as a duplicate of this bug. *** Question: Has the fix for this issue been released? I am run Helios for RCP and I am having this issue while going through the plugin tutorial. The only helloworld-feature.xml file I can find is in the /configuration/bundles/210/1/.cp/cheatsheets/helloworld. I tried to copy the fixed copyright lines into the file. Did not work. Thank you. The fix is available in builds for 3.7 M1 (I20100804-0100) and 3.6 Maintenance release (M20100728-0800) or later. (In reply to comment #18) > The fix is available in builds for 3.7 M1 (I20100804-0100) and 3.6 Maintenance > release (M20100728-0800) or later. What is the URL for getting these fixes? Verified. |