Bugzilla – Full Text Bug Listing
| Summary: | RM Proxy options don't get saved. | ||
|---|---|---|---|
| Product: | [Tools] PTP | Reporter: | Roland Schulz <roland> |
| Component: | RM | Assignee: | Roland Schulz <roland> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | arossi, drwootton |
| Version: | 4.0 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | All | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 316672 | ||
|
Description
Roland Schulz
Are proxy options actually used for anything? (In reply to comment #1) > Are proxy options actually used for anything? (I marked it as 5.0 milestone because it is nothing which needs to be solved urgently - just made the bug-report so I wouldn't forget) I'm not sure. I noticed that the additional arguments don't work, because I tried to use them for debugging. I wrote code that the "Proxy options" are passed to the jvm as options (e.g. -Xdebug). But it doesn't work because the "Proxy options" are not saved. I'm not sure whether it is a good idea to use the "Proxy options" as a field to enter jvm options. But we probably should remove that button if it doesn't work. As a temporary solution, I just directly change proxy.xml to be able to debug the proxy. These are used by the PE proxy to give the user the ability to choose at runtime whether the PE proxy will communicate with LoadLeveler to manage resource allocation as well as for some flags to help with debugging the proxy. The LoadLeveler proxy uses these for options like polling intervals and where to get the job submit template from. Proxy options should be save, so if anyone feels like fixing it, please go ahead. I think that generally the proxy options are being saved. The problem Roland reports looks like it's specific to the popup dialog that appears when the 'Proxy Options' button button is clicked, and where options don't appear to be properly saved. If I set options in the LoadLeveler proxy invocation options wizard panel that appears when you click 'next' in the RM configuration wizard and click checkboxes, those do get saved. There is a problem where the library path override and template path override settings in this dialog do not get saved, which I've observed before but have had no time to try to fix. I did experiment with PE proxy settings and those do get saved, so I think this is limited to the LoadLeveler proxy. The other problem I see is that the 'Connection name' dropdown doesn't fill in the saved connection name when the RM configuration wizard is opened. If there are multiple connection names in the list, when the RM config wizard is opened, it seems to pick the first name in the list. If I pick a connection other than the first in the list, and complete the wizard the connection name I chose is used. If I restart Eclipse, the correct connection is still used. If I reopen the RM config wizard and fail to note that the connection name dropdown now has the first connection on the list, then trying to start the RM after completing the wizard fails. Both of these bugs seem limited in scope to me. The LL proxy options because using the following dialog to set options seems to work, and the second because I kind of doubt a user is going to have multiple connections to proxies on multiple nodes. Should I try to fix these in the next week or defer them? Note that the LoadLeveler proxy is kind of an oddball case since it has both a 'Proxy options' dialog with a simple text entry field and a following wizard page with checkboxes, etc. I suspect there's some conflicts in the handling of options between those two dialogs. The right course of action in fixing this I think is to move the 2nd LL RM wizard page so that it appears when the 'Proxy Options' button is clicked and not when the next button is clicked. That makes the wizard flow consistent with other resource managers. Dave, please open a separate bug on the connection list problem. Just to chime in here; the incorrect saving behavior may be an artifact of how I patched (hacked?) this class so as not to display the path to the proxy executable when the flag is set to false in a child class such as the PBS RM. This feels wrong to me (there should be another class layer), but it was a fast and dirty solution to go hand-in-hand with the automatic deployment of the proxy. Fixed in HEAD and 4.0 branch |